D20694: Use regular stat when resolving a symlink

2019-04-20 Thread Méven Car
meven added a comment. In D20694#453296 , @dfaure wrote: > I fixed them ;-) Nice back to stable tests! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20694 To: meven, dfaure, #frameworks Cc: bcooksley, kde-framewor

D20694: Use regular stat when resolving a symlink

2019-04-20 Thread David Faure
dfaure added a comment. I fixed them ;-) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20694 To: meven, dfaure, #frameworks Cc: bcooksley, kde-frameworks-devel, michaelh, ngraham, bruns

D20694: Use regular stat when resolving a symlink

2019-04-20 Thread Méven Car
meven added a comment. Regressions are fixed : https://build.kde.org/view/OS%20-%20Windows/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/95/testReport/junit/projectroot/autotests/kiowidgets_kdirmodeltest/history/ https://build.kde.org/view/OS%20-%20Windows/job/Frameworks/job/kio/job/kf5

D20694: Use regular stat when resolving a symlink

2019-04-20 Thread Méven Car
meven added a comment. https://build.kde.org/view/OS - Windows/job/Frameworks/job/kio/job/kf5-qt5 SUSEQt5.10/95 Will confirm if this is fixed. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20694 To: meven, dfaure, #frameworks Cc: bcooksley, kde-frameworks-devel, micha

D20694: Use regular stat when resolving a symlink

2019-04-20 Thread Méven Car
This revision was automatically updated to reflect the committed changes. Closed by commit R241:dfbc18403297: Use regular stat when resolving a symlink (authored by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20694?vs=56616&id=56618 REVISION DETAIL h

D20694: Use regular stat when resolving a symlink

2019-04-20 Thread Méven Car
meven added a comment. In D20694#453252 , @bcooksley wrote: > The Gitlab migration is in planning and preparation stages, so should happen sometime in the next couple of months. I can't wait for gitlab migration. phabricator is quite n

D20694: Use regular stat when resolving a symlink

2019-04-20 Thread Ben Cooksley
bcooksley added a comment. The Gitlab migration is in planning and preparation stages, so should happen sometime in the next couple of months. REPOSITORY R241 KIO BRANCH fix-test REVISION DETAIL https://phabricator.kde.org/D20694 To: meven, dfaure, #frameworks Cc: bcooksley, kde-fram

D20694: Use regular stat when resolving a symlink

2019-04-20 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Glad that the unittest caught an actual bug for once :-) Yes we'd all love pre-merge CI checks, but that won't happen with phabricator. I hear rumours of a migration to gitlab at some p

D20694: Use regular stat when resolving a symlink

2019-04-20 Thread Méven Car
meven added a reviewer: Frameworks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20694 To: meven, dfaure, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20694: Use regular stat when resolving a symlink

2019-04-20 Thread Méven Car
meven created this revision. meven added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Before f3b0f220a78d4e5a5b94b46e931779d755ac19ce