D20665: use the base implementation hints

2019-04-18 Thread Marco Martin
This revision was automatically updated to reflect the committed changes. Closed by commit R296:d9a0365ccc49: use the base implementation hints (authored by mart). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20665?vs=56534&id=56535 REVISION DETAIL h

D20665: use the base implementation hints

2019-04-18 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. +1 shipit! REPOSITORY R296 KDeclarative BRANCH phab/hints REVISION DETAIL https://phabricator.kde.org/D20665 To: mart, #plasma, ngraham Cc: ngraham, kde-frameworks-devel, michaelh

D20665: use the base implementation hints

2019-04-18 Thread Marco Martin
mart updated this revision to Diff 56534. mart retitled this revision from "Use the base implementation hints" to "use the base implementation hints". mart edited the summary of this revision. mart added a comment. - remove visual debug REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDAT

D20665: use the base implementation hints

2019-04-18 Thread Nathaniel Graham
ngraham retitled this revision from "use the base implementation hints" to "Use the base implementation hints". ngraham edited the summary of this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D20665 To: mart, #plasma Cc: kde-frameworks-devel, michaelh,

D20665: use the base implementation hints

2019-04-18 Thread Marco Martin
mart added a comment. F6779963: Screenshot_20190418_164550.png REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D20665 To: mart, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20665: use the base implementation hints

2019-04-18 Thread Marco Martin
mart created this revision. mart added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY with latest kirigami master and kcmutils, the default size hints of scrollablepage are correc