D20659: Copy container in Component::cleanUp before interating

2019-04-18 Thread Fabian Vogt
fvogt added a comment. In D20659#452642 , @ngraham wrote: > Did this fix https://bugs.kde.org/show_bug.cgi?id=406642? No, that particular crash (bug 406426) is already fixed. I marked it as dup. REPOSITORY R268 KGlobalAccel REVISION DE

D20659: Copy container in Component::cleanUp before interating

2019-04-18 Thread Nathaniel Graham
ngraham added a comment. Did this fix https://bugs.kde.org/show_bug.cgi?id=406642? REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D20659 To: fvogt, #frameworks, davidedmundson Cc: ngraham, lbeltrame, kde-frameworks-devel, michaelh, bruns

D20659: Copy container in Component::cleanUp before interating

2019-04-18 Thread Fabian Vogt
This revision was automatically updated to reflect the committed changes. Closed by commit R268:78a711361db3: Copy container in Component::cleanUp before interating (authored by fvogt). REPOSITORY R268 KGlobalAccel CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20659?vs=56517&id=5652

D20659: Copy container in Component::cleanUp before interating

2019-04-18 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R268 KGlobalAccel BRANCH master REVISION DETAIL https://phabricator.kde.org/D20659 To: fvogt, #frameworks, davidedmundson Cc: lbeltrame, kde-frameworks-devel, michaelh, ngraham, bruns

D20659: Copy container in Component::cleanUp before interating

2019-04-18 Thread Fabian Vogt
fvogt retitled this revision from "Detach container in Component::cleanUp before interating" to "Copy container in Component::cleanUp before interating". REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D20659 To: fvogt, #frameworks Cc: lbeltrame, kde-frameworks-deve