dfaure added a comment.
No, it's pretty much the same. The garbage looks a bit different, but
switching to another email and back fixes it, so no big deal. I thought this
was what this whole effort was about, though :-)
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kd
davidedmundson added a comment.
> Thanks, this fixes the plasma crash on resume.
Thanks for the fast reports / testing.
> [KMail's webengine view still displays garbage on resume, but that's less
critical, and unrelated to this patch]
Is it worse than before any of the QSurfaceF
This revision was automatically updated to reflect the committed changes.
Closed by commit R296:0aab7d23a2ce: Plotter: Scope GL Program to lifespan of
scenegraph node (authored by davidedmundson).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D20656?vs=56505&id=56549#toc
REPOSITORY
R29
dfaure added a comment.
Thanks, this fixes the plasma crash on resume.
[KMail's webengine view still displays garbage on resume, but that's less
critical, and unrelated to this patch]
REPOSITORY
R296 KDeclarative
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D20656
T
broulik accepted this revision.
broulik added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> plotter.cpp:267
> +PlotSGNode();
> +void bind(){
> +m_program->bind();
Coding style
REPOSITORY
R296 KDeclarative
BRANCH
master
REVISION DETAIL
davidedmundson edited the summary of this revision.
davidedmundson edited the test plan for this revision.
davidedmundson added a reviewer: dfaure.
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D20656
To: davidedmundson, #plasma, dfaure
Cc: kde-frameworks-devel, mi
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
Currently the QOpenGLProgram was static. This works when you only
