This revision was automatically updated to reflect the committed changes.
Closed by commit R127:6da6c7c7e090: Implement set_window_geometry (authored by
davidedmundson).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D20595?vs=56357&id=58071#toc
REPOSITORY
R127 KWayland
CHANGES SINCE L
zzag accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R127 KWayland
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D20595
To: davidedmundson, #kwin, zzag
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns
davidedmundson added a comment.
marking inline comments as done
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D20595
To: davidedmundson, #kwin
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns
zzag added a comment.
> Maybe we can revisit once I've done the kwin side?
Sure.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D20595
To: davidedmundson, #kwin
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns
davidedmundson marked 2 inline comments as done.
davidedmundson added a comment.
> What about xdg_shell_unstable_v6?
Code wise it's a super easy copy + paste.
I'm somewhat torn when it comes to adding new "features" to deprecated specs
that I can't do real-world testing of.
Maybe
davidedmundson updated this revision to Diff 56357.
davidedmundson added a comment.
update
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D20595?vs=56353&id=56357
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D20595
AFFECTED FILES
autot
zzag added inline comments.
INLINE COMMENTS
> xdgshell_interface.h:283
> + * @brief windowGeometry
> + * The position of the window within the buffer
> + *
s/position/geometry/
> xdgshell_stable_interface.cpp:524
> +if (s->m_topLevel) {
> +s->m_topLevel->d_func()->window
zzag added a comment.
What about xdg_shell_unstable_v6?
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D20595
To: davidedmundson, #kwin
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns
davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
Used by clients to say where their true window geometry is relative
