D20558: Bug fix: find c++ stl using regex

sh-zam added a comment. well.. I couldn't get it running as a toolchain and kept running into errors. I can give it another hit, though. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D20558 To: sh-zam, apol Cc: kde-buildsystem, kde-frameworks-devel,

D20558: Bug fix: find c++ stl using regex

apol added a comment. In D20558#451898 , @sh-zam wrote: > In my case if I do this: `include (Android.cmake)`, then it won't be able to find the `ECMAndroidDeployQt.cmake` because I am using android-ndk's toolchain. And why do you have to

D20558: Bug fix: find c++ stl using regex

This revision was automatically updated to reflect the committed changes. Closed by commit R240:307b36662ec9: Bug fix: find c++ stl using regex (authored by sh-zam). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20558?vs=56311&id=56445 REVISION D

D20558: Bug fix: find c++ stl using regex

sh-zam added a comment. > What does it mean that "it expects to run as a toolchain"? Sorry, I didn't notice this. On this line get_filename_component(_CMAKE_ANDROID_DIR "${CMAKE_

D20558: Bug fix: find c++ stl using regex

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH arcpatch-D20558 REVISION DETAIL https://phabricator.kde.org/D20558 To: sh-zam, apol Cc: kde-buildsystem, kde-frameworks-devel, bencreasy, michaelh, ngraham, bruns

D20558: Bug fix: find c++ stl using regex

sh-zam added inline comments. INLINE COMMENTS > apol wrote in ECMAndroidDeployQt.cmake:43 > This looks quite awful. Why do you prefer using regex to string(FIND)? It > could be something like > `string(FIND "${VALUE}" "c++.so\"" OUT)` if you want to be more specific. Because `string (FIND ..)`

D20558: Bug fix: find c++ stl using regex

apol added a comment. In D20558#450229 , @sh-zam wrote: > > Why are you using it without Android.cmake? > > I am building Krita and to add `create-apk` target I am using `include (ECMAndroidDeployQt.cmake)`, I can't use `Android.cmake` becaus

D20558: Bug fix: find c++ stl using regex

sh-zam updated this revision to Diff 56311. sh-zam added a comment. - disallow whitespaces in path REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20558?vs=56257&id=56311 BRANCH arcpatch-D20558 REVISION DETAIL https://phabricator.kde.org/D2

D20558: Bug fix: find c++ stl using regex

sh-zam added a comment. > Why are you using it without Android.cmake? I am building Krita and to add `create-apk` target I am using `include (ECMAndroidDeployQt.cmake)`, I can't use `Android.cmake` because of some variables as it expects to run as a toolchain. Later today, I will su

D20558: Bug fix: find c++ stl using regex

sh-zam updated this revision to Diff 56257. sh-zam added a comment. - disallow whitespaces in path REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20558?vs=56243&id=56257 BRANCH arcpatch-D20558 REVISION DETAIL https://phabricator.kde.org/D2

D20558: Bug fix: find c++ stl using regex

apol added a comment. In D20558#450198 , @sh-zam wrote: > Can we add a `cmake_minimum_required` to `3.7`? Regex fails to compile on older versions, when run outside of `Android.cmake`. Sure, add it. Why are you using it without Android.

D20558: Bug fix: find c++ stl using regex

sh-zam added a comment. Can we add a `cmake_minimum_required` to `3.7`? Regex fails to compile on older versions, when run outside of `Android.cmake`. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D20558 To: sh-zam, apol Cc: kde-buildsystem, kde-framewo

D20558: Bug fix: find c++ stl using regex

sh-zam created this revision. sh-zam added a reviewer: apol. Herald added projects: Frameworks, Build System. Herald added a subscriber: kde-buildsystem. sh-zam requested review of this revision. REVISION SUMMARY Find C++ shared lib path using regex. This change makes finding path independent