D20264: Add test for "Auto Reload Document" option

dhaumann added a comment. Yes, that's exactly what I meant. But if it's not stable, then it does not help. Maybe in that case keep it as is for now? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20264 To: loh.tar, dhaumann, cullmann Cc: cullmann, kwrite-devel,

D20264: Add test for "Auto Reload Document" option

loh.tar added a comment. @dhaumann asked elsewhere > Instead of waiting so long, we could alternatively also have a while loop waiting up to 20 times for 50ms. This way, the test would be faster if possible. Like this? diff --git a/autotests/src/katedocument_test.cpp b/autote

D20264: Add test for "Auto Reload Document" option

This revision was automatically updated to reflect the committed changes. Closed by commit R39:f5f715ea1441: Add test for "Auto Reload Document" option (authored by loh.tar). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D20264?vs=55576&id=56623#toc REPOSITORY R39 KTextEditor CHANGES

D20264: Add test for "Auto Reload Document" option

loh.tar added a comment. I spend a couple of time for this stuff. Would be nice someone else could try it or do some investigation with tools I'm not familiar with, and don't want to be atm. Without feedback I will push it in the next few days. REVISION DETAIL https://phabricator.kde.or

D20264: Add test for "Auto Reload Document" option

cullmann accepted this revision. cullmann added a comment. I think this can go in as is, as long as the test works determinstically, which I assume it does. REVISION DETAIL https://phabricator.kde.org/D20264 To: loh.tar, dhaumann, cullmann Cc: cullmann, kwrite-devel, kde-frameworks-devel,

D20264: Add test for "Auto Reload Document" option

loh.tar added a comment. In D20264#448583 , @dhaumann wrote: > I think KateViewInternal::updateView is called for cursor blinking for instance. May that be an issue? Regarding ... > KateViewInternal::updateView is very often called

D20264: Add test for "Auto Reload Document" option

dhaumann added a comment. I think KateViewInternal::updateView is called for cursor blinking for instance. May that be an issue? REVISION DETAIL https://phabricator.kde.org/D20264 To: loh.tar, dhaumann Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, michaelh, ngraham

D20264: Add test for "Auto Reload Document" option

loh.tar updated this revision to Diff 55576. loh.tar edited the summary of this revision. loh.tar added a comment. - Enhance the test by checks for proper cursor position While adding your tiny change, it pointed out, that the test was not correct regarding needed waiting times. Pls compa

D20264: Add test for "Auto Reload Document" option

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. There is a getter bool KateGlobal::self()->unitTestMode(). You could use this in DocumentPrivate to reduce the timer from 3000 to e.g. 50ms or so to reduce testing time. But beside

D20264: Add test for "Auto Reload Document" option

loh.tar created this revision. loh.tar added a reviewer: dhaumann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D20264 A