D20233: Add syntax highlighting for fish shell

This revision was automatically updated to reflect the committed changes. Closed by commit R216:0e2d7e61a256: Add syntax highlighting for fish shell (authored by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20233?vs=55361&id=56093 REV

D20233: Add syntax highlighting for fish shell

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Ok, then we keep that license and push this as is. Thanks for the contribution, btw.! REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D20233 To

D20233: Add syntax highlighting for fish shell

adiestelhorst added a comment. I found nothing helpfull for this question. There is still the list of Unix commands, where I did only small additions and which is nearly half the lines of code. When in doubt, I think it is better to stick to the rules. So I would like to keep it LGPL.

D20233: Add syntax highlighting for fish shell

cullmann added a comment. If you think you nearly changed everything, I guess MIT is ok. If you think still too much is derived, I can live with LGPL ;=) I let you decide. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D20233 To: adiestelhorst, #frame

D20233: Add syntax highlighting for fish shell

adiestelhorst added a comment. In D20233#444099 , @cullmann wrote: > Thanks for the contribution. > On a first glance, that looks ok, no hard coded colors, test case, ... > We would prefer if the license would be MIT, is that possible?

D20233: Add syntax highlighting for fish shell

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. Thanks for the contribution. On a first glance, that looks ok, no hard coded colors, test case, ... We would prefer if the license would be MIT, is that possible? REPOSITOR

D20233: Add syntax highlighting for fish shell

nibags edited the summary of this revision. nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D20233 To: adiestelhorst, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-deve

D20233: Add syntax highlighting for fish shell

adiestelhorst created this revision. adiestelhorst added a project: Framework: Syntax Highlighting. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. adiestelhorst requested review of this revision. REVISION SUMMARY For fish shell version 2.7.