apol abandoned this revision.
REPOSITORY
R273 KGuiAddons
REVISION DETAIL
https://phabricator.kde.org/D20193
To: apol, romangg, dfaure
Cc: alexeymin, zzag, romangg, dfaure, kde-frameworks-devel, LeGast00n,
michaelh, ngraham, bruns
alexeymin added inline comments.
INLINE COMMENTS
> dfaure wrote in kmodifierkeyinfoprovider.cpp:90
> Calling this an "abuse" is very arguable, see
> https://herbsutter.com/2013/08/12/gotw-94-solution-aaa-style-almost-always-auto/
> I'm not aware of a KF5 policy about this, so it's fine as is.
T
dfaure added inline comments.
INLINE COMMENTS
> zzag wrote in kmodifierkeyinfoprovider.cpp:90
> Abuse of `auto`.
Calling this an "abuse" is very arguable, see
https://herbsutter.com/2013/08/12/gotw-94-solution-aaa-style-almost-always-auto/
I'm not aware of a KF5 policy about this, so it's fine
zzag added inline comments.
INLINE COMMENTS
> kmodifierkeyinfo.cpp:34-44
> +#ifdef WITH_XCB
> +if (qGuiApp->platformName() == QLatin1String("xcb"))
> +return new KModifierKeyInfoProviderXcb;
> +else
> +#endif
> +#ifdef WITH_WAYLAND
> +if (qGuiApp->platformName() == QLatin1Stri
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> keystate.xml:22
> +
> +xxx
> +
Interesting description. Does the number of 'x' mean anything? ;)
> kmodifierkeyinfoprovider_w
romangg accepted this revision.
romangg added a comment.
This revision is now accepted and ready to land.
Please add description, otherwise let's try it out.
REPOSITORY
R273 KGuiAddons
BRANCH
wayland_keystate
REVISION DETAIL
https://phabricator.kde.org/D20193
To: apol, romangg
Cc: rom
apol edited the summary of this revision.
apol edited the test plan for this revision.
REPOSITORY
R273 KGuiAddons
REVISION DETAIL
https://phabricator.kde.org/D20193
To: apol
Cc: dfaure, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
apol retitled this revision from "Depends on D20191" to "Expose locked
keystates on KModifierKeyInfo when on wayland".
apol edited the summary of this revision.
apol added a dependency: D20191: Proof of concept of a wayland protocol to
allow the keystate dataengine to work.
REPOSITORY
R273 KGu
