D20158: Allow to set urgency for notifications

broulik added a dependent revision: D20651: Support default action, priority hints, set desktop-entry. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D20158 To: broulik, #plasma, #frameworks, vkrause, ogoffart, mck182 Cc: mlaurent, kde-frameworks-devel, michaelh,

D20158: Allow to set urgency for notifications

broulik added a comment. Good point, I shall space them apart a bit. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D20158 To: broulik, #plasma, #frameworks, vkrause, ogoffart, mck182 Cc: mlaurent, kde-frameworks-devel, michaelh, ngraham, bruns

D20158: Allow to set urgency for notifications

vkrause added a comment. In D20158#452099 , @broulik wrote: > @vkrause I just noticed xdg portal notification spec (the ones used for sandboxed flatpak apps) has four urgency levels: low, normal, *high*, critical. > Do you think it would be us

D20158: Allow to set urgency for notifications

broulik added a comment. @vkrause I just noticed xdg portal notification spec (the ones used for sandboxed flatpak apps) has four urgency levels: low, normal, *high*, critical. Do you think it would be useful to add `HighUrgency`, too? For Android, maybe? For freedesktop Notifications we co

D20158: Allow to set urgency for notifications

This revision was automatically updated to reflect the committed changes. Closed by commit R289:39c6e0ea805c: Allow to set urgency for notifications (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D20158?vs=55173&id=55726#toc REPOSITORY R289 KNotifications CHANGES

D20158: Allow to set urgency for notifications

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D20158 To: broulik, #plasma, #frameworks, vkrause, ogoffart, mck182 Cc: mlaurent, kde-frameworks-devel, michaelh, ngraham, bruns

D20158: Allow to set urgency for notifications

broulik added a comment. Ping? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D20158 To: broulik, #plasma, #frameworks, vkrause, ogoffart, mck182 Cc: mlaurent, kde-frameworks-devel, michaelh, ngraham, bruns

D20158: Allow to set urgency for notifications

vkrause added a comment. Yep, code looks good to me too, so +1 on this :) REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D20158 To: broulik, #plasma, #frameworks, vkrause, ogoffart, mck182 Cc: mlaurent, kde-frameworks-devel, michaelh, ngraham, bruns

D20158: Allow to set urgency for notifications

broulik added a comment. So, in essence you're fine with adding the enum as it is, and then have some mapping in the Android code? :) REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D20158 To: broulik, #plasma, #frameworks, vkrause, ogoffart, mck182 Cc: mlaure

D20158: Allow to set urgency for notifications

vkrause added a comment. I was looking at https://developer.android.com/training/notify-user/channels#importance which also has IMPORTANCE_LOW mapped to "medium". But yes, it's basically just about finding a suitable mapping, even if we don't cover every possible level on Android. REPOSITO

D20158: Allow to set urgency for notifications

broulik added a comment. In D20158#441322 , @vkrause wrote: > Nicely fits with the Android backend too, although that has one extra level (low, medium, high, urgent). I found the following enums in `NotificationManager`: - `IMPORTANC

D20158: Allow to set urgency for notifications

vkrause added a comment. Nicely fits with the Android backend too, although that has one extra level (low, medium, high, urgent). REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D20158 To: broulik, #plasma, #frameworks, vkrause, ogoffart, mck182 Cc: kde-framew

D20158: Allow to set urgency for notifications

broulik created this revision. broulik added reviewers: Plasma, Frameworks, vkrause, ogoffart, mck182. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY This lets the application set an urgency hint on