D20013: Use Qt function for string list formatting

2019-03-27 Thread Alexander Stippich
This revision was automatically updated to reflect the committed changes. Closed by commit R286:3a83a49a4350: Use Qt function for string list formatting (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20013?vs=54951&id=54954 REVI

D20013: Use Qt function for string list formatting

2019-03-27 Thread Stefan Brüns
bruns accepted this revision. bruns added a comment. This revision is now accepted and ready to land. Worst that can happen is a translators just happens to translate it **now**, and then it is just some unnecessary, but trivial work done without need. REPOSITORY R286 KFileMetaData BRANCH

D20013: Use Qt function for string list formatting

2019-03-27 Thread Alexander Stippich
astippich added a comment. Is removing a string allowed during string freeze? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20013 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bru

D20013: Use Qt function for string list formatting

2019-03-27 Thread Alexander Stippich
astippich removed a dependency: D19445: Handle variant list in formatting functions. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20013 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham,

D20013: Use Qt function for string list formatting

2019-03-27 Thread Alexander Stippich
astippich updated this revision to Diff 54951. astippich added a comment. - rebase directly on master REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20013?vs=54653&id=54951 BRANCH string_list_formatting REVISION DETAIL https://phabricator.kde.or

D20013: Use Qt function for string list formatting

2019-03-25 Thread Stefan Brüns
bruns requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20013 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngrah

D20013: Use Qt function for string list formatting

2019-03-25 Thread Stefan Brüns
bruns added a comment. I think this should go in before D19445 . INLINE COMMENTS > propertyinfo.cpp:635 > if (d->valueType == QVariant::StringList || d->valueType == > QVariant::String ) { > return FormatStrings::joinStringListFunctio

D20013: Use Qt function for string list formatting

2019-03-24 Thread Alexander Stippich
astippich added a dependency: D19445: Handle variant list in formatting functions. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20013 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, b

D20013: Use Qt function for string list formatting

2019-03-24 Thread Alexander Stippich
astippich created this revision. astippich added a reviewer: bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Reuse existing Qt function to convert string lists into string REP