This revision was automatically updated to reflect the committed changes.
Closed by commit R289:06a61528cd48: Allow to set custom hints for notifications
(authored by nicolasfella).
REPOSITORY
R289 KNotifications
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D19978?vs=54669&id=54671
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R289 KNotifications
BRANCH
hints
REVISION DETAIL
https://phabricator.kde.org/D19978
To: nicolasfella, broulik, davidedmundson
Cc: vkrause, kde-frameworks-devel, michaelh, ngraham, bruns
vkrause added a comment.
+1
REPOSITORY
R289 KNotifications
REVISION DETAIL
https://phabricator.kde.org/D19978
To: nicolasfella, broulik
Cc: vkrause, kde-frameworks-devel, michaelh, ngraham, bruns
nicolasfella edited the summary of this revision.
REPOSITORY
R289 KNotifications
REVISION DETAIL
https://phabricator.kde.org/D19978
To: nicolasfella, broulik
Cc: vkrause, kde-frameworks-devel, michaelh, ngraham, bruns
nicolasfella updated this revision to Diff 54669.
nicolasfella added a comment.
- doc ++
REPOSITORY
R289 KNotifications
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D19978?vs=54573&id=54669
BRANCH
hints
REVISION DETAIL
https://phabricator.kde.org/D19978
AFFECTED FILES
sr
vkrause added a comment.
Technically this looks ok to me, might be useful to have a little bit more
context in the documentation and/or commit message though
REPOSITORY
R289 KNotifications
REVISION DETAIL
https://phabricator.kde.org/D19978
To: nicolasfella, broulik
Cc: vkrause, kde-fram
broulik added a comment.
+1
REPOSITORY
R289 KNotifications
REVISION DETAIL
https://phabricator.kde.org/D19978
To: nicolasfella, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
nicolasfella updated this revision to Diff 54573.
nicolasfella added a comment.
- fix stuff
REPOSITORY
R289 KNotifications
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D19978?vs=54570&id=54573
BRANCH
hints
REVISION DETAIL
https://phabricator.kde.org/D19978
AFFECTED FILES
nicolasfella updated this revision to Diff 54570.
nicolasfella added a comment.
- const'ify
REPOSITORY
R289 KNotifications
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D19978?vs=54569&id=54570
BRANCH
hints
REVISION DETAIL
https://phabricator.kde.org/D19978
AFFECTED FILES
nicolasfella created this revision.
nicolasfella added a reviewer: broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.
REVISION SUMMARY
Allow to send custom hints to the notification implementation.
REPOSI
10 matches
Mail list logo