D19961: Properly fix copy constructor

2019-03-22 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > resultiterator.cpp:53 > { > -qWarning("ResultIterator copy constructor being used. This is crashy"); > +d->results = rhs.d->results; > } why not pos? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D19961

D19961: Properly fix copy constructor

2019-03-22 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes. Closed by commit R293:ccb9b19e1e74: Properly fix copy constructor (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19961?vs=54525&id=54566 REVISION DETAIL https://pha

D19961: Properly fix copy constructor

2019-03-22 Thread Nathaniel Graham
ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH fix_copy_constructor REVISION DETAIL https://phabricator.kde.org/D19961 To: bruns, #baloo, #frameworks, ngraham, poboiko Cc: kde-frameworks-devel, gennad, domson, ashaposhnikov, m

D19961: Properly fix copy constructor

2019-03-21 Thread Stefan Brüns
bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Instead of printing a warning (which probably nobody would