D19850: Make AppStream generation opt-in

2019-04-26 Thread Aleix Pol Gonzalez
apol abandoned this revision. REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D19850 To: apol, #plasma, ngraham Cc: sitter, ngraham, kde-frameworks-devel, michaelh, bruns

D19850: Make AppStream generation opt-in

2019-04-14 Thread Nathaniel Graham
ngraham added a comment. Ping! Can we land this or a variant of it? REPOSITORY R290 KPackage BRANCH master REVISION DETAIL https://phabricator.kde.org/D19850 To: apol, #plasma, ngraham Cc: sitter, ngraham, kde-frameworks-devel, michaelh, bruns

D19850: Make AppStream generation opt-in

2019-03-27 Thread Nathaniel Graham
ngraham added a comment. In D19850#439332 , @sitter wrote: > LGTM technically. Also looks crazy scary invasive though from a packaging POV :O > > What if a third party user of kpackage actively relied on the appstream data being auto-generat

D19850: Make AppStream generation opt-in

2019-03-27 Thread Nathaniel Graham
ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R290 KPackage BRANCH master REVISION DETAIL https://phabricator.kde.org/D19850 To: apol, #plasma, ngraham Cc: sitter, ngraham, kde-frameworks-devel, michaelh, bruns

D19850: Make AppStream generation opt-in

2019-03-27 Thread Harald Sitter
sitter added a comment. LGTM technically. Also looks crazy scary invasive though from a packaging POV :O What if a third party user of kpackage actively relied on the appstream data being auto-generated? Wouldn't this change in behavior essentially break backwards compatibility? Perhaps

D19850: Make AppStream generation opt-in

2019-03-18 Thread Nathaniel Graham
ngraham edited the summary of this revision. REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D19850 To: apol, #plasma Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19850: Make AppStream generation opt-in

2019-03-18 Thread Nathaniel Graham
ngraham added a comment. Conceptual +1; giving everything autogenerated yet sparse AppStream data doesn't provide much value and causes various problems with how app store apps (e.g. Discover) present our software. See https://bugs.kde.org/show_bug.cgi?id=403120. AppStream data should ideall

D19850: Make AppStream generation opt-in

2019-03-18 Thread Aleix Pol Gonzalez
apol created this revision. apol added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY After discussing the feature over it became apparent that developers will need to be pro-activ