D19812: Add a web page to view and compare icons of different sizes

ngraham added a comment. If you want to use a library, then it would be better to mark it as a dependency in CMake rather than bundling it here. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19812 To: guoyunhe, ngraham, #vdg, ndavis, #breeze Cc: ltoscano, fil

D19812: Add a web page to view and compare icons of different sizes

guoyunhe abandoned this revision. guoyunhe added a comment. Using a library can save a lot of time. Just like many simple web pages use jQuery, D3 , etc. I don't have the ability to write it all by hands from scratch... REPOSITORY R266 Breeze Icons REVI

D19812: Add a web page to view and compare icons of different sizes

ngraham added a comment. At the minimum, I'd like to see the original/un-minified version rather than the illegible version here that's vulnerable to attack. But why do we even need it in the first place? The original is 12,000 lines of Javascript. Is it actually necessary to have such a thi

D19812: Add a web page to view and compare icons of different sizes

guoyunhe added a comment. In D19812#456869 , @ltoscano wrote: > The documentation website of krita is a different type of repository. This project is going to be distributed and compiled by the distributions, and many of them will have to patch

D19812: Add a web page to view and compare icons of different sizes

ltoscano added a comment. The documentation website of krita is a different type of repository. This project is going to be distributed and compiled by the distributions, and many of them will have to patch out the minified javascript and replace it with a dependency on a proper packaged ver

D19812: Add a web page to view and compare icons of different sizes

guoyunhe added a comment. The code is stable version Vue.js. Source is here https://github.com/vuejs/vue/blob/v2.6.10/dist/vue.min.js Uncompiled version is here https://github.com/vuejs/vue/blob/v2.6.10/dist/vue.js I used to include it from remote URL. But someone think it is not trust

D19812: Add a web page to view and compare icons of different sizes

filipf added a comment. In D19812#456848 , @ngraham wrote: > What is this giant javascript file with no whitespace that you're adding? I really don't like how it's formatted in such a way that makes the code practically impossible to read. This

D19812: Add a web page to view and compare icons of different sizes

guoyunhe added a comment. In D19812#456848 , @ngraham wrote: > What is this giant javascript file with no whitespace that you're adding? I really don't like how it's formatted in such a way that makes the code practically impossible to read. Thi

D19812: Add a web page to view and compare icons of different sizes

ngraham added a comment. What is this giant javascript file with no whitespace that you're adding? I really don't like how it's formatted in such a way that makes the code practically impossible to read. This would be the perfect place to sneak in malware (not saying you or the author have d

D19812: Add a web page to view and compare icons of different sizes

ndavis added a comment. In D19812#455478 , @ngraham wrote: > TBH I wonder how useful this actually is. Hopefully some of the other folks involved in making icons (@ndavis, @GB_2, @trickyricky26) can comment on whether or not this would be useful

D19812: Add a web page to view and compare icons of different sizes

GB_2 added a comment. I personally think this could be quite useful. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19812 To: guoyunhe, ngraham, #vdg, ndavis, #breeze Cc: trickyricky26, GB_2, pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns

D19812: Add a web page to view and compare icons of different sizes

ngraham added subscribers: GB_2, trickyricky26. ngraham added a comment. TBH I wonder how useful this actually is. Hopefully some of the other folks involved in making icons (@ndavis, @GB_2, @trickyricky26) can comment on whether or not this would be useful for them. REPOSITORY R266 Breeze

D19812: Add a web page to view and compare icons of different sizes

guoyunhe added a comment. Hi @ngraham @pino @bcooksley , I have updated the script/configuration. Can you give some further opinion? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19812 To: guoyunhe, ngraham, #vdg, ndavis, #breeze Cc: pino, bcooksley, ngraham,

D19812: Add a web page to view and compare icons of different sizes

guoyunhe added a comment. Hi all, Can you check if here is anything else that needs to be changed? Thanks. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19812 To: guoyunhe, ngraham, #vdg, ndavis, #breeze Cc: pino, bcooksley, ngraham, kde-frameworks-devel,

D19812: Add a web page to view and compare icons of different sizes

guoyunhe marked 5 inline comments as done. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19812 To: guoyunhe, ngraham, #vdg, ndavis, #breeze Cc: pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns

D19812: Add a web page to view and compare icons of different sizes

guoyunhe updated this revision to Diff 54919. guoyunhe added a comment. Output to stderr REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19812?vs=54918&id=54919 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19812 AFFECTED FILES .gi

D19812: Add a web page to view and compare icons of different sizes

guoyunhe updated this revision to Diff 54918. guoyunhe added a comment. Don't use remote JavaScript library REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19812?vs=54688&id=54918 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19812 A

D19812: Add a web page to view and compare icons of different sizes

pino added a comment. In D19812#436174 , @guoyunhe wrote: > In D19812#436154 , @pino wrote: > > > - please harden the script using at least -e and -u flags for set: this way, it will not keep executi

D19812: Add a web page to view and compare icons of different sizes

guoyunhe updated this revision to Diff 54688. guoyunhe added a comment. Fix typo REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19812?vs=54546&id=54688 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19812 AFFECTED FILES .gitignore

D19812: Add a web page to view and compare icons of different sizes

ngraham added inline comments. INLINE COMMENTS > generate_web_data.sh:7 > +then > +echo "Error: Directory $DIR/icons does not exists." > +exit exists -> exist > generate_web_data.sh:13 > +then > +echo "Error: Directory $DIR/icons-dark does not exists." > +exit ditto REPOSITORY

D19812: Add a web page to view and compare icons of different sizes

guoyunhe updated this revision to Diff 54546. guoyunhe added a comment. Improve bash script REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19812?vs=54535&id=54546 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19812 AFFECTED FILES

D19812: Add a web page to view and compare icons of different sizes

guoyunhe added a comment. In D19812#436154 , @pino wrote: > - please harden the script using at least -e and -u flags for set: this way, it will not keep executing when a command fails, and undeclared variables are not silently expanded to empty

D19812: Add a web page to view and compare icons of different sizes

pino added a comment. Few notes on the new `generate_web_data.sh` script: - please quote the paths properly, otherwise it will break when either the source directory or the build directory contain e.g. spaces - it does not seem using any bash-specific features, so make it using `/bin/s

D19812: Add a web page to view and compare icons of different sizes

guoyunhe updated this revision to Diff 54535. guoyunhe added a comment. Add search function REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19812?vs=54533&id=54535 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19812 AFFECTED FILES

D19812: Add a web page to view and compare icons of different sizes

guoyunhe added a comment. F6709477: image.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19812 To: guoyunhe, ngraham, #vdg, ndavis, #breeze Cc: bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns

D19812: Add a web page to view and compare icons of different sizes

guoyunhe updated this revision to Diff 54533. guoyunhe added a comment. Add color blind mode REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19812?vs=54532&id=54533 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19812 AFFECTED FILES

D19812: Add a web page to view and compare icons of different sizes

guoyunhe updated this revision to Diff 54532. guoyunhe added a comment. Move build files to CMake build directory REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19812?vs=54257&id=54532 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19

D19812: Add a web page to view and compare icons of different sizes

ngraham added a comment. They should all go into the build dir IMO. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19812 To: guoyunhe, ngraham, #vdg, ndavis, #breeze Cc: bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns

D19812: Add a web page to view and compare icons of different sizes

guoyunhe added a comment. In D19812#434089 , @ngraham wrote: > Thanks, it compiles with CMake now! \o/ > > I'm not a fan of how it dumps all this stuff in the source directory. Ideally it would put everything to the build directory when doing

D19812: Add a web page to view and compare icons of different sizes

ngraham added a comment. Thanks, it compiles with CMake now! \o/ I'm not a fan of how it dumps all this stuff in the source directory. Ideally it would put everything to the build directory when doing an out-of-source build so the source dir isn't cluttered up with transient and rapidly-

D19812: Add a web page to view and compare icons of different sizes

ndavis added a comment. In D19812#433941 , @guoyunhe wrote: > In D19812#433916 , @ndavis wrote: > > > Could you use `#eff0f1` and `#31363b` for the light and dark backgrounds since those are the colo

D19812: Add a web page to view and compare icons of different sizes

guoyunhe updated this revision to Diff 54257. guoyunhe added a comment. Use typical Breeze background colors REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19812?vs=54252&id=54257 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19812

D19812: Add a web page to view and compare icons of different sizes

guoyunhe added a comment. In D19812#433916 , @ndavis wrote: > Could you use `#eff0f1` and `#31363b` for the light and dark backgrounds since those are the colors we normally use for window backgrounds? Like this? F6700542: image.png

D19812: Add a web page to view and compare icons of different sizes

ndavis added a comment. Could you use `#eff0f1` and `#31363b` for the light and dark backgrounds since those are the colors we normally use for window backgrounds? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19812 To: guoyunhe, ngraham, #vdg, ndavis, #breez

D19812: Add a web page to view and compare icons of different sizes

guoyunhe added a comment. In D19812#432424 , @ngraham wrote: > Getting closer: > > Scanning dependencies of target generate-web > make[2]: generate_web_data.sh: Command not found > CMakeFiles/generate-web.dir/build.make:57: recipe fo

D19812: Add a web page to view and compare icons of different sizes

guoyunhe updated this revision to Diff 54252. guoyunhe added a comment. Add ${CMAKE_SOURCE_DIR} prefix to script REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19812?vs=54051&id=54252 BRANCH master REVISION DETAIL https://phabricator.kde.org/D198

D19812: Add a web page to view and compare icons of different sizes

ngraham added a comment. Getting closer: Scanning dependencies of target generate-web make[2]: generate_web_data.sh: Command not found CMakeFiles/generate-web.dir/build.make:57: recipe for target 'CMakeFiles/generate-web' failed Are you able to test this yourself? REPOSITO

D19812: Add a web page to view and compare icons of different sizes

guoyunhe updated this revision to Diff 54051. guoyunhe added a comment. Move outside of generate_binary_resource REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19812?vs=54050&id=54051 BRANCH master REVISION DETAIL https://phabricator.kde.org/D198

D19812: Add a web page to view and compare icons of different sizes

guoyunhe added a comment. In D19812#432348 , @bcooksley wrote: > I assume this fetches the icons from your local system? yes. it depends on text files generated by scripts, which contains list of all icons REPOSITORY R266 Breeze Icons

D19812: Add a web page to view and compare icons of different sizes

ngraham added a comment. mmm, I'm afraid that didn't work. running `cmake` on it reveals the following: CMake Error at CMakeLists.txt:71 (add_custom_target): add_custom_target cannot create target "generate-web" because another target with the same name already exists. The e

D19812: Add a web page to view and compare icons of different sizes

bcooksley added a comment. I assume this fetches the icons from your local system? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19812 To: guoyunhe, ngraham, #vdg, ndavis, #breeze Cc: bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns

D19812: Add a web page to view and compare icons of different sizes

guoyunhe updated this revision to Diff 54050. guoyunhe added a comment. Remove unnecessary spaces REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19812?vs=54049&id=54050 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19812 AFFECTED FI

D19812: Add a web page to view and compare icons of different sizes

guoyunhe added a comment. In D19812#432326 , @ngraham wrote: > Neato! Looks pretty handy. Two issues I found: > > - generate_web_data.sh isn't executable > - I'd like to see this run as part of the build process, so that `index.html` gets u

D19812: Add a web page to view and compare icons of different sizes

guoyunhe updated this revision to Diff 54049. guoyunhe added a comment. Add CMake build steps for web page REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19812?vs=54048&id=54049 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19812 AF

D19812: Add a web page to view and compare icons of different sizes

guoyunhe edited the summary of this revision. guoyunhe added a reviewer: Breeze. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19812 To: guoyunhe, ngraham, #vdg, ndavis, #breeze Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19812: Add a web page to view and compare icons of different sizes

ngraham added reviewers: VDG, ndavis. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19812 To: guoyunhe, ngraham, #vdg, ndavis Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19812: Add a web page to view and compare icons of different sizes

guoyunhe updated this revision to Diff 54048. guoyunhe added a comment. Fix data updating issues REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19812?vs=54047&id=54048 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19812 AFFECTED FIL

D19812: Add a web page to view and compare icons of different sizes

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Neato! Looks pretty handy. Two issues I found: - generate_web_data.sh isn't executable - I'd like to see this run as part of the build process, so that `index.html` gets u

D19812: Add a web page to view and compare icons of different sizes

guoyunhe created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. guoyunhe requested review of this revision. REVISION SUMMARY This simple web page provides a table of all icons. So developers can easily know which icon size is missing, or no