This revision was automatically updated to reflect the committed changes.
Closed by commit R216:ed2b54803d1c: Add Smali syntax highlighting file
(authored by davispuh, committed by cullmann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D19811?vs=
cullmann accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R216 Syntax Highlighting
BRANCH
smali
REVISION DETAIL
https://phabricator.kde.org/D19811
To: davispuh, cullmann, dhaumann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh,
cullmann added a comment.
Ok, thanks, think that can go in ;=)
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D19811
To: davispuh, cullmann, dhaumann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham,
bruns, demsking, cul
davispuh updated this revision to Diff 54631.
davispuh added a comment.
Reduce size of test file
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D19811?vs=54120&id=54631
BRANCH
smali
REVISION DETAIL
https://phabricator.kde.org/D19811
AFFECT
cullmann added a comment.
Hmm, if the license is ok, perhaps the smaller RealSmaliFileTest.smali you
linked above would make a better test case, >> 5000 lines is a bit large for
reviewing changes later ;=)
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D
davispuh updated this revision to Diff 54120.
davispuh added a comment.
Add a test
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D19811?vs=54046&id=54120
BRANCH
smali
REVISION DETAIL
https://phabricator.kde.org/D19811
AFFECTED FILES
aut
cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.
I think we will need a auto-test file for this ;=)
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D19811
To: davispuh, cullmann, dhaumann
davispuh updated this revision to Diff 54046.
davispuh added a comment.
Use MIT license
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D19811?vs=54045&id=54046
BRANCH
smali
REVISION DETAIL
https://phabricator.kde.org/D19811
AFFECTED FILES
davispuh created this revision.
davispuh added reviewers: cullmann, dhaumann, vkrause.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
davispuh requested review of this revision.
TEST PLAN
Open
https://github.com/JesusFreke/smali/blob/maste
