hallas closed this revision.
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D19767
To: hallas, #frameworks, dfaure, sitter, aacid
Cc: aacid, kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh,
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emma
aacid accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R320 KIO Extras
BRANCH
fix_malloc_delete_mismatch (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D19767
To: hallas, #frameworks, dfaure, sitter, aacid
Cc: aacid, kde-frameworks-de
hallas added a comment.
Good catch ;) I have changed it to call `ssh_string_free_char` instead
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D19767
To: hallas, #frameworks, dfaure, sitter
Cc: aacid, kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh,
sp
hallas updated this revision to Diff 54054.
hallas marked 2 inline comments as done.
hallas added a comment.
Use ssh_string_free_char instead of free as documentated by libssh
REPOSITORY
R320 KIO Extras
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D19767?vs=53911&id=54054
BRANCH
sitter added inline comments.
INLINE COMMENTS
> aacid wrote in kio_sftp.cpp:446
> Use ssh_string_free_char ?
+1
"The caller needs to free the memory using ssh_string_free_char()."
http://api.libssh.org/stable/group__libssh__sftp.html#gab4860a441da019060f78c8d236d9ec91
REPOSITORY
R320 KIO Ex
aacid added inline comments.
INLINE COMMENTS
> kio_sftp.cpp:446
> cPath = QFile::decodeName(sPath);
> -delete sPath;
> +free(sPath);
>
Use ssh_string_free_char ?
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D19767
To: hallas, #frameworks, dfaure, s
broulik added a reviewer: sitter.
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D19767
To: hallas, #frameworks, dfaure, sitter
Cc: kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun,
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mi
anthonyfieroni added a reviewer: dfaure.
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D19767
To: hallas, #frameworks, dfaure
Cc: kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun,
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mik
hallas created this revision.
hallas added a reviewer: Frameworks.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
hallas requested review of this revision.
REVISION SUMMARY
Fixes pointer was allocated with malloc (by libssh) but freed with
