This revision was automatically updated to reflect the committed changes.
Closed by commit R242:ebae2d630336: Remove crash in plasmashell (authored by
mlaurent).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D19698?vs=53707&id=53712
REVISIO
mlaurent updated this revision to Diff 53707.
mlaurent added a comment.
Fix coding style
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D19698?vs=53703&id=53707
BRANCH
remove_crash_bug_405351 (branched from master)
REVISION DETAIL
ht
broulik accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
remove_crash_bug_405351 (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D19698
To: mlaurent, dfaure, #frameworks, #plasma, broulik
Cc: brou
broulik requested changes to this revision.
broulik added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> datamodel.cpp:67
> {
> -return sourceModel()->roleNames();
> +if (sourceModel())
> + return sourceModel()->roleNames();
Coding style, braces
lbeltrame added reviewers: Frameworks, Plasma.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D19698
To: mlaurent, dfaure, #frameworks, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
mlaurent created this revision.
mlaurent added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.
REVISION SUMMARY
remove bug in plasmashell Bug 405341
TEST PLAN
can't reproduce bug
REPOSITORY
