This revision was automatically updated to reflect the committed changes.
Closed by commit R278:ab99c870d6ca: Support NET_WM_STATE_FOCUSED (authored by
davidedmundson).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D19617?vs=53460&id=57182#toc
REPOSITORY
R278 KWindowSystem
CHANGES SIN
ngraham added inline comments.
INLINE COMMENTS
> ngraham wrote in netwm_def.h:506
> It's 5.57; 5.56 has already been tagged.
5.58 at this point.
REPOSITORY
R278 KWindowSystem
BRANCH
state_focussed
REVISION DETAIL
https://phabricator.kde.org/D19617
To: davidedmundson, #kwin, broulik
Cc:
broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.
I think regardless of whether we end up using this in KWin or not, we should
have the API for it in `KWindowSystem`
REPOSITORY
R278 KWindowSystem
BRANCH
state_focussed
REVISION DETA
ngraham added inline comments.
INLINE COMMENTS
> davidedmundson wrote in netwm_def.h:506
> Whatever I put in @since is always wrong by the time I commit it anyway
It's 5.57; 5.56 has already been tagged.
REPOSITORY
R278 KWindowSystem
REVISION DETAIL
https://phabricator.kde.org/D19617
To:
apol added a comment.
+1 otherwise
INLINE COMMENTS
> netwininfotestwm.cpp:440
> const QByteArray demandsAttention =
> QByteArrayLiteral("_NET_WM_STATE_DEMANDS_ATTENTION");
> +const QByteArray focused = QByteArrayLiteral("_NET_WM_STATE_FOCUSED");
> +
Indent with the rest? :P
REPOSI
davidedmundson added inline comments.
INLINE COMMENTS
> zzag wrote in netwm_def.h:506
> 5.56 or 5.57?
Whatever I put in @since is always wrong by the time I commit it anyway
REPOSITORY
R278 KWindowSystem
REVISION DETAIL
https://phabricator.kde.org/D19617
To: davidedmundson, #kwin
Cc: zzag
zzag added inline comments.
INLINE COMMENTS
> netwm_def.h:506
> + Only the window manager is allowed to change it.
> + @since 5.56
> + **/
5.56 or 5.57?
REPOSITORY
R278 KWindowSystem
REVISION DETAIL
https://phabricator.kde.org/D19617
To: davidedmundson, #kwin
Cc:
davidedmundson added a dependency: D19613: Support NET_WM_STATE_FOCUSED.
REPOSITORY
R278 KWindowSystem
REVISION DETAIL
https://phabricator.kde.org/D19617
To: davidedmundson, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.
TEST PLAN
Used in kwin
Unit test
REPOSITORY
R278 KWindowSystem
BRANCH
state_
