D19506: ECMGeneratePkgConfigFile: add variables used by pkg_check_modules

dfaure added a comment. Makes sense --> https://phabricator.kde.org/D19538 REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D19506 To: dfaure, apol, fazevedo, cgiboudeaux Cc: kossebau, cgiboudeaux, fazevedo, kde-buildsystem, kde-frameworks-devel, michaelh,

D19506: ECMGeneratePkgConfigFile: add variables used by pkg_check_modules

kossebau added a comment. FWIW, this still results in inproper pc files, from what I heard recently. The `prefix` variable can be overriden from outside when calling `pkg-config` (cmp. `pkg-config --help`) to allow for relocatable installations. Same like CMake Config files also allow reloca

D19506: ECMGeneratePkgConfigFile: add variables used by pkg_check_modules

dfaure closed this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D19506 To: dfaure, apol, fazevedo, cgiboudeaux Cc: cgiboudeaux, fazevedo, kde-buildsystem, kde-frameworks-devel, michaelh, ngraham, bruns

D19506: ECMGeneratePkgConfigFile: add variables used by pkg_check_modules

cgiboudeaux accepted this revision. cgiboudeaux added a comment. This revision is now accepted and ready to land. Thanks. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D19506 To: dfaure, apol, fazevedo, cgiboudeaux Cc: cgiboudeaux, fazev

D19506: ECMGeneratePkgConfigFile: add variables used by pkg_check_modules

dfaure updated this revision to Diff 53114. dfaure added a comment. Update unittests, passes now REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19506?vs=53108&id=53114 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19506 AFFEC

D19506: ECMGeneratePkgConfigFile: add variables used by pkg_check_modules

cgiboudeaux added a comment. In D19506#424301 , @cgiboudeaux wrote: > The autotest has to be fixed as well Comment edited, the includedir value is correct for this test. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://ph

D19506: ECMGeneratePkgConfigFile: add variables used by pkg_check_modules

cgiboudeaux requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D19506 To: dfaure, apol, fazevedo, cgiboudeaux Cc: cgiboudeaux, fazevedo, kde-buildsystem, kde-frameworks-devel, mich

D19506: ECMGeneratePkgConfigFile: add variables used by pkg_check_modules

cgiboudeaux added a comment. The autotest has to be fixed as well The includedir value looks bogus, the test file contains includedir=/usr/KCoreAddons REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D19506 To: dfaure, apol, faz

D19506: ECMGeneratePkgConfigFile: add variables used by pkg_check_modules

fazevedo accepted this revision. fazevedo added a comment. This revision is now accepted and ready to land. Works for me ! REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D19506 To: dfaure, apol, fazevedo Cc: fazevedo, kde-buildsystem, kde

D19506: ECMGeneratePkgConfigFile: add variables used by pkg_check_modules

dfaure created this revision. dfaure added a reviewer: apol. Herald added projects: Frameworks, Build System. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY If we ever end up in a situation where the generated .pc file is actually us