D19486: Add UDev find module

2019-03-04 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R240:8999b7bd6f6d: Add UDev find module (authored by vkrause). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D19486?vs=53055&id=53160#toc REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UP

D19486: Add UDev find module

2019-03-03 Thread Christophe Giboudeaux
cgiboudeaux accepted this revision. cgiboudeaux added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > FindUDev.cmake:86 > +set(UDEV_INCLUDE_DIR ${UDev_INCLUDE_DIRS}) > + > +include(FeatureSummary) mark_as_advanced(UDEV_FOUND UDEV_LIBS UDEV_INCLUDE_DIR) REPOSI

D19486: Add UDev find module

2019-03-03 Thread Volker Krause
vkrause updated this revision to Diff 53055. vkrause added a comment. Add backward compatibility variables. REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19486?vs=53047&id=53055 BRANCH master REVISION DETAIL https://phabricator.kde.org/D1

D19486: Add UDev find module

2019-03-03 Thread Christophe Giboudeaux
cgiboudeaux added a comment. In D19486#423728 , @cgiboudeaux wrote: > We probably need to set uppercase variables for the moment. plasma-desktop and powerdevil include the ECM modules dir before their local copy, so any older release would fail

D19486: Add UDev find module

2019-03-03 Thread Christophe Giboudeaux
cgiboudeaux added a comment. We probably need to set uppercase variables for the moment. plasma-desktop and powerdevil include the ECM modules dir before their local copy, so any older release would fail to build with ECM >= 5.57 INLINE COMMENTS > FindUDev.cmake:24 > +# The UDev library

D19486: Add UDev find module

2019-03-03 Thread Volker Krause
vkrause created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This one is originally coming from Solid, but there are several more copies in our reposi