D19446: DocumentPrivate: Support auto bracket in block selection mode

This revision was automatically updated to reflect the committed changes. Closed by commit R39:ad4cd4a72508: DocumentPrivate: Support auto bracket in block selection mode (authored by loh.tar). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19446?vs=55355&i

D19446: DocumentPrivate: Support auto bracket in block selection mode

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. The new functionality works ok enough for me. For the other issues you found with the cursor updates and the range stuff I would like different patches if we want to tackle them. R

D19446: DocumentPrivate: Support auto bracket in block selection mode

loh.tar added a comment. > Edit: The issue is located here... > > TextBlock::insertText(...) > ... > // special handling if cursor behind the real line, e.g. non-wrapping cursor in block selection mode > else if (cursor->m_column < textOfLine.size()) { >

D19446: DocumentPrivate: Support auto bracket in block selection mode

loh.tar added a comment. In D19446#442303 , @loh.tar wrote: > >> Feature or bug? Select in block mode from right->left on a single line after last char a block. The brackets are exchanged )( and placed at the end of the block > > > > Hmm, I

D19446: DocumentPrivate: Support auto bracket in block selection mode

loh.tar updated this revision to Diff 55355. loh.tar edited the test plan for this revision. loh.tar set the repository for this revision to R39 KTextEditor. loh.tar added a comment. - Bring back call of view->slotTextInserted I think it's ready for a new review REPOSITORY R39 KTextEdit

D19446: DocumentPrivate: Support auto bracket in block selection mode

loh.tar updated this revision to Diff 55346. loh.tar edited the summary of this revision. loh.tar edited the test plan for this revision. loh.tar added a comment. - Ensure the new added brackets will not be part of the selection when selection was done from right->left - Enhance autotest

D19446: DocumentPrivate: Support auto bracket in block selection mode

loh.tar updated this revision to Diff 55303. loh.tar set the repository for this revision to R39 KTextEditor. loh.tar added a comment. - Set proper start/end column independent from selection direction. REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D194

D19446: DocumentPrivate: Support auto bracket in block selection mode

loh.tar updated this revision to Diff 55284. loh.tar added a comment. - QCOMPARE also the selection in tests CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19446?vs=55280&id=55284 REVISION DETAIL https://phabricator.kde.org/D19446 AFFECTED FILES autotests/src/katedocument_test.

D19446: DocumentPrivate: Support auto bracket in block selection mode

loh.tar added a comment. >> Feature or bug? Select in block mode from right->left on a single line after last char a block. The brackets are exchanged )( and placed at the end of the block > > Hmm, I think this counts as a bug. Have trouble to reproduce now. Was that fixed somewhere

D19446: DocumentPrivate: Support auto bracket in block selection mode

loh.tar updated this revision to Diff 55280. loh.tar edited the test plan for this revision. loh.tar added a comment. - Add some auto tests CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19446?vs=55272&id=55280 REVISION DETAIL https://phabricator.kde.org/D19446 AFFECTED FILES a

D19446: DocumentPrivate: Support auto bracket in block selection mode

loh.tar updated this revision to Diff 55272. loh.tar added a comment. - Rebase on master CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19446?vs=52906&id=55272 REVISION DETAIL https://phabricator.kde.org/D19446 AFFECTED FILES src/document/katedocument.cpp To: loh.tar, #ktexted

D19446: DocumentPrivate: Support auto bracket in block selection mode

cullmann requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19446 To: loh.tar, #ktexteditor, cullmann Cc: cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, micha

D19446: DocumentPrivate: Support auto bracket in block selection mode

cullmann added a comment. Hi, I think this is an improvement. Could you update the patch to current master? For your questions: - Feature or bug? Select in block mode from right->left on a single line after last char a block. The brackets are exchanged )( and placed at the

D19446: DocumentPrivate: Support auto bracket in block selection mode

loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY ..how it should be by adding brackets to each line of the block