D19418: Make it compiles without deprecated method

2019-03-12 Thread Kai Uwe Broulik
broulik reopened this revision. broulik added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > datamodel.cpp:67 > +{ > +return sourceModel()->roleNames(); > +} Likely culprit here, `sourceModel()` being `null` REPOSITORY R242 Plasma Framework (Library)

D19418: Make it compiles without deprecated method

2019-03-12 Thread Kai Uwe Broulik
broulik requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19418 To: mlaurent, dfaure, apol, broulik Cc: broulik, arojas, kde-frameworks-devel, michaelh, ngraham, bruns

D19418: Make it compiles without deprecated method

2019-03-11 Thread Antonio Rojas
arojas added a comment. This is making Plasma crash, see https://bugs.kde.org/show_bug.cgi?id=405351 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19418 To: mlaurent, dfaure, apol Cc: arojas, kde-frameworks-devel, michaelh, ngraham, bruns

D19418: Make it compiles without deprecated method

2019-02-28 Thread Laurent Montel
This revision was automatically updated to reflect the committed changes. Closed by commit R242:9fc663d9f0ed: Make it compiles without deprecated method (authored by mlaurent). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19418?vs=52818&id

D19418: Make it compiles without deprecated method

2019-02-28 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH remove_deprecated_methods (branched from master) REVISION DETAIL https://phabricator.kde.org/D19418 To: mlaurent, dfaure, apol Cc: kde-frameworks-devel, michaelh

D19418: Make it compiles without deprecated method

2019-02-28 Thread Laurent Montel
mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without deprecated method TEST PLAN all autotest ok REPOSITORY R242 P