mlaurent added a comment.
Fixed
REPOSITORY
R274 KIdleTime
REVISION DETAIL
https://phabricator.kde.org/D19318
To: mlaurent, dfaure
Cc: hindenburg, kde-frameworks-devel, michaelh, ngraham, bruns
hindenburg added a comment.
There's a FOREACH still in the macpoller.cpp file
REPOSITORY
R274 KIdleTime
REVISION DETAIL
https://phabricator.kde.org/D19318
To: mlaurent, dfaure
Cc: hindenburg, kde-frameworks-devel, michaelh, ngraham, bruns
This revision was automatically updated to reflect the committed changes.
Closed by commit R274:b072248cc681: compile without foreach (authored by
mlaurent).
REPOSITORY
R274 KIdleTime
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D19318?vs=52560&id=53042
REVISION DETAIL
https://ph
dfaure accepted this revision.
dfaure added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> kidletime.cpp:253
>
> if (associations.values().contains(msec)) {
> +const auto listKeys = associations.keys(msec);
Urgh, how horrible and slow. But pre-
mlaurent created this revision.
mlaurent added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.
REVISION SUMMARY
compile without foreach
REPOSITORY
R274 KIdleTime
BRANCH
compile_without_fore
