This revision was automatically updated to reflect the committed changes.
Closed by commit R287:f1c6c15b061b: compile without foreach (authored by
mlaurent).
REPOSITORY
R287 KImageFormats
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D19317?vs=52700&id=52863
REVISION DETAIL
https:
apol accepted this revision.
apol added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> imagedump.cpp:75
> out << "File formats:\n";
> -foreach (const QByteArray &fmt,
> QImageReader::supportedImageFormats()) {
> +const QList lstSuppor
mlaurent updated this revision to Diff 52700.
mlaurent added a comment.
Use auto as requested
REPOSITORY
R287 KImageFormats
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D19317?vs=52559&id=52700
BRANCH
compile_without_foreach (branched from master)
REVISION DETAIL
https://ph
mlaurent added inline comments.
INLINE COMMENTS
> apol wrote in pic.cpp:391
> Probably could do a splitRef here
it seems that we can't use it.
As it will return a list of QStringRef
and we want to use "simplified() on a QStringRef which doesn't exist
REPOSITORY
R287 KImageFormats
REVISION DE
apol added inline comments.
INLINE COMMENTS
> pic.cpp:391
> m_description.clear();
> -QStringList entries =
> value.toString().split(QStringLiteral("\n\n"));
> -Q_FOREACH(const QString entry, entries) {
> +const QStringList entries =
> value.toSt
mlaurent created this revision.
mlaurent added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.
REVISION SUMMARY
compile without foreach
REPOSITORY
R287 KImageFormats
BRANCH
compile_without_
