D19263: Add more highlighting for nested languages in markdown.

dhaumann added a comment. Good idea, thanks. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D19263 To: vandenoever, #framework_syntax_highlighting, dhaumann Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, dem

D19263: Add more highlighting for nested languages in markdown.

cullmann added a comment. Jos fixed it in commit 1653403267ed9ad0a27ee4042be8e0d714a5dcc4 I made that check now required. All current files pass, people can comment out contexts during development.

D19263: Add more highlighting for nested languages in markdown.

dhaumann added a comment. Hi Jos, could you please check again the output of the highlighting indexer? ContextChecker::check: "/home/dh/kde/kf5/src/frameworks/syntax-highlighting/data/syntax/markdown.xml" Unused contexts: QSet("kconfig-code") The checker says that this context is

D19263: Add more highlighting for nested languages in markdown.

vandenoever added a comment. done REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D19263 To: vandenoever, #framework_syntax_highlighting, dhaumann Cc: dhaumann, kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, demsking, cullmann, sars

D19263: Add more highlighting for nested languages in markdown.

dhaumann added a comment. Well, if it's fixed by adding the missing reference update then please do so. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D19263 To: vandenoever, #framework_syntax_highlighting, dhaumann Cc: dhaumann, kwrite-devel, kde-framewo

D19263: Add more highlighting for nested languages in markdown.

vandenoever added a comment. I see that one test fails after committing this patch. The example output was modified by `/autotests/update-reference-data.sh` but I did not submit it. I thought it was not related to the markdown change. REPOSITORY R216 Syntax Highlighting REVISION DETAIL

D19263: Add more highlighting for nested languages in markdown.

This revision was automatically updated to reflect the committed changes. Closed by commit R216:bbb5188d9e12: Add more highlighting for nested languages in markdown. (authored by vandenoever). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19263?vs

D19263: Add more highlighting for nested languages in markdown.

vandenoever updated this revision to Diff 52430. vandenoever added a comment. Increased kateversion to 5.0. REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19263?vs=52410&id=52430 BRANCH nested (branched from master) REVISION DETAIL https:/

D19263: Add more highlighting for nested languages in markdown.

dhaumann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH nested (branched from master) REVISION DETAIL https://phabricator.kde.org/D19263 To: vandenoever, #framework_syntax_highlighting, dhaumann Cc: dhaumann, kwrite-deve

D19263: Add more highlighting for nested languages in markdown.

dhaumann added a comment. Looks good to me, thanks. Before committing, could you increase the kateversion="5.0" in the language xml element as well? Otherwise KDE 4 users could get this via the download dialog as well, without getting the depending files due to 5.0 requirements in the o

D19263: Add more highlighting for nested languages in markdown.

vandenoever added a comment. Even folding works inside fenced blocks. After running `./autotests/update-reference-data.sh` `autotests/folding/example.rmd.fold` changed. I did not commit that change. The language version is now updated and I added a few more languages. REPOSITORY R

D19263: Add more highlighting for nested languages in markdown.

vandenoever updated this revision to Diff 52410. vandenoever added a comment. - added more languages, - updated language version - updated test files REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19263?vs=52395&id=52410 BRANCH nested (br

D19263: Add more highlighting for nested languages in markdown.

dhaumann added a comment. Could you extend autotests/input/test.markdown ? Then call ./autotests/update-reference-data.sh in the build folder to copy the changes into the src folder, and update this patch. PS: And increase the "version" in the langauge xml element at the beginning of t

D19263: Add more highlighting for nested languages in markdown.

vandenoever retitled this revision from "yAdd more highlighting for nested languages in markdown." to "Add more highlighting for nested languages in markdown.". REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D19263 To: vandenoever, #framework_syntax_highlig