This revision was automatically updated to reflect the committed changes.
Closed by commit R243:ff2240350387: Make it compiles without foreach (authored
by mlaurent).
REPOSITORY
R243 KArchive
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D19251?vs=52377&id=52426
REVISION DETAIL
ht
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
Ah, no, you're right.
I remembered that there was a problem with function calls (rvalues) but that
problem is not what I thought, it's the fact that one can't write
qAsConst(myFunc())
mlaurent added inline comments.
INLINE COMMENTS
> dfaure wrote in krcc.cpp:147
> move to temp var to avoid detaching?
dir is const. Will it detach ?
REPOSITORY
R243 KArchive
REVISION DETAIL
https://phabricator.kde.org/D19251
To: mlaurent, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> krcc.cpp:147
> {
> -Q_FOREACH (const QString &fileName, dir.entryList()) {
> +for (const QString &fileName : dir.entryList()) {
> const QStri
mlaurent created this revision.
mlaurent added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
mlaurent requested review of this revision.
REPOSITORY
R243 KArchive
BRANCH
compile_without_foreach (branched from master)
REVISION DETAIL
