This revision was automatically updated to reflect the committed changes.
apol marked an inline comment as done.
Closed by commit R238:acf8d5352402: Only report DocBookXML as found if it was
actually found (authored by apol).
REPOSITORY
R238 KDocTools
CHANGES SINCE LAST UPDATE
https://phabri
ltoscano accepted this revision.
ltoscano added a comment.
This revision is now accepted and ready to land.
Right, sorry.
REPOSITORY
R238 KDocTools
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D19224
To: apol, #frameworks, ltoscano
Cc: kde-frameworks-devel, kde-doc-englis
apol marked an inline comment as done.
apol added inline comments.
INLINE COMMENTS
> ltoscano wrote in FindDocBookXML4.cmake:88
> Isn't ${found_dir} undefined at this point?
no, this is an argument to the function and it has to contain the output
variable, as used in the line 86.
REPOSITORY
ltoscano added a comment.
Sorry, I forgot to save a comment.
INLINE COMMENTS
> FindDocBookXML4.cmake:88
> +else()
> +message(WARNING "${found_dir}: Could not find docbookx.dtd in
> ${CMAKE_SYSTEM_PREFIX_PATH} with suffixes ${DTD_PATH_LIST}")
> +endif()
Isn't ${found_dir} und
apol added a comment.
@ltoscano you said that you want changes to happen but didn't mention what
needs changing?
REPOSITORY
R238 KDocTools
REVISION DETAIL
https://phabricator.kde.org/D19224
To: apol, #frameworks, ltoscano
Cc: kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngra
ltoscano requested changes to this revision.
This revision now requires changes to proceed.
REPOSITORY
R238 KDocTools
REVISION DETAIL
https://phabricator.kde.org/D19224
To: apol, #frameworks, ltoscano
Cc: kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, bruns,
skadinna
apol updated this revision to Diff 52296.
apol added a comment.
Include a warning about how it wasn't found
REPOSITORY
R238 KDocTools
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D19224?vs=52293&id=52296
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D19224
AFFE
apol created this revision.
apol added a reviewer: Frameworks.
Herald added projects: Frameworks, Documentation.
Herald added subscribers: kde-doc-english, kde-frameworks-devel.
apol requested review of this revision.
REVISION SUMMARY
Otherwise we generate files with paths such as
"searched_dir
