D19215: Install DefinitionDownloader header

2019-02-24 Thread Dominik Haumann
This revision was automatically updated to reflect the committed changes. Closed by commit R216:df18fada76b2: Install DefinitionDownloader header (authored by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19215?vs=52269&id=52478 REVISI

D19215: Install DefinitionDownloader header

2019-02-24 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D19215 To: davschul, cullmann, vkrause Cc: dhaumann, kwrite-devel, kde-frameworks-devel, bmortimer, domson, michaelh, genethomas,

D19215: Install DefinitionDownloader header

2019-02-24 Thread Dominik Haumann
dhaumann added a comment. I also do not see an issue with this. But I would like to add some background info that may be interesting: Downloading the syntax highlighting files will download all files, and not just the ones that changed etc. This by itself is fine, since it guarantees co

D19215: Install DefinitionDownloader header

2019-02-24 Thread Christoph Cullmann
cullmann added a comment. I would have no issues with this if Volker is ok, too. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D19215 To: davschul, cullmann, vkrause Cc: kwrite-devel, kde-frameworks-devel, bmortimer, domson, michaelh, genethomas, ngraha

D19215: Install DefinitionDownloader header

2019-02-21 Thread David Schulz
davschul created this revision. davschul added reviewers: cullmann, vkrause. davschul added a project: Framework: Syntax Highlighting. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. davschul requested review of this revision. REVISION SUMMARY