D19168: Fix crash in Dolphin when dropping trashed file in trash

This revision was automatically updated to reflect the committed changes. Closed by commit R241:f56af9e2ea0a: Fix crash in Dolphin when dropping trashed file in trash (authored by hallas). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19168?vs=52508&id=52509 REV

D19168: Fix crash in Dolphin when dropping trashed file in trash

hallas updated this revision to Diff 52508. hallas added a comment. Rebase REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19168?vs=52132&id=52508 BRANCH fix_crash_when_dropping_trashed_file_in_trash (branched from master) REVISION DETAIL https://phabricat

D19168: Fix crash in Dolphin when dropping trashed file in trash

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH fix_crash_when_dropping_trashed_file_in_trash (branched from master) REVISION DETAIL https://phabricator.kde.org/D19168 To: hallas, #frameworks, elvisangelaccio, ngraham, dfaure Cc:

D19168: Fix crash in Dolphin when dropping trashed file in trash

hallas added a comment. @dfaure - do you have any other comments for this commit? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19168 To: hallas, #frameworks, elvisangelaccio, ngraham, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19168: Fix crash in Dolphin when dropping trashed file in trash

hallas marked 3 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19168 To: hallas, #frameworks, elvisangelaccio, ngraham, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19168: Fix crash in Dolphin when dropping trashed file in trash

hallas updated this revision to Diff 52132. hallas added a comment. Implemented review comments REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19168?vs=52105&id=52132 BRANCH fix_crash_when_dropping_trashed_file_in_trash (branched from master) REVISION DETAI

D19168: Fix crash in Dolphin when dropping trashed file in trash

hallas added a comment. In D19168#415767 , @dfaure wrote: > Looks good, just some minor improvement suggestions for the unittest. Thanks for the suggestions - I am still quite new to using QtTest :) Essentially I copied one of the other u

D19168: Fix crash in Dolphin when dropping trashed file in trash

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Looks good, just some minor improvement suggestions for the unittest. INLINE COMMENTS > dropjobtest.cpp:361 > +KIO::CopyJob *copyJob = KIO::move(QUrl::fromLocalFile(m_srcF

D19168: Fix crash in Dolphin when dropping trashed file in trash

dhaumann added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19168 To: hallas, #frameworks, elvisangelaccio, ngraham, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19168: Fix crash in Dolphin when dropping trashed file in trash

hallas added reviewers: elvisangelaccio, ngraham. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19168 To: hallas, #frameworks, elvisangelaccio, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19168: Fix crash in Dolphin when dropping trashed file in trash

hallas created this revision. hallas added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. hallas requested review of this revision. REVISION SUMMARY Fix crash in Dolphin when dropping trashed file in trash. The actual crash happens