D19163: Make it possible to show all spaces in the document

This revision was automatically updated to reflect the committed changes. Closed by commit R39:0a9aeb183314: Make it possible to show all spaces in the document (authored by apol, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19163?

D19163: Make it possible to show all spaces in the document

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. I think that is ok now, thanks for the nifty feature. REPOSITORY R39 KTextEditor BRANCH master REVISION DETAIL https://phabricator.kde.org/D19163 To: apol, #kate, cullmann Cc: c

D19163: Make it possible to show all spaces in the document

apol updated this revision to Diff 52320. apol added a comment. Fix tabs REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19163?vs=52319&id=52320 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19163 AFFECTED FILES autotests/src/vimode/

D19163: Make it possible to show all spaces in the document

apol updated this revision to Diff 52319. apol added a comment. Use an enum instead of two booleans REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19163?vs=52260&id=52319 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19163 AFFECTED FI

D19163: Make it possible to show all spaces in the document

cullmann added a comment. In D19163#417139 , @apol wrote: > In D19163#415907 , @cullmann wrote: > > > I like the feature, but for the implementation: Could we alter the config to itself hold the enu

D19163: Make it possible to show all spaces in the document

apol updated this revision to Diff 52260. apol added a comment. oops REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19163?vs=52084&id=52260 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19163 AFFECTED FILES src/dialogs/katedialogs.c

D19163: Make it possible to show all spaces in the document

apol added a comment. In D19163#415907 , @cullmann wrote: > I like the feature, but for the implementation: Could we alter the config to itself hold the enum? We could do that, I just didn't not to break currently existing systems >

D19163: Make it possible to show all spaces in the document

cullmann added a comment. I like the feature, but for the implementation: Could we alter the config to itself hold the enum? An other thing: why was the non-printable regex altered? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19163 To: apol, #kate Cc: cullm

D19163: Make it possible to show all spaces in the document

ngraham added a comment. I have wanted this for so long! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19163 To: apol, #kate Cc: ngraham, kwrite-devel, kde-frameworks-devel, gennad, michaelh, bruns, demsking, cullmann, sars, dhaumann

D19163: Make it possible to show all spaces in the document

apol added a comment. F6624272: kate-spaces.png REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19163 To: apol, #kate Cc: kwrite-devel, kde-frameworks-devel, gennad, michaelh, ngraham, bruns, demsking, cullmann, sars, dhauma

D19163: Make it possible to show all spaces in the document

apol created this revision. apol added a reviewer: Kate. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. apol requested review of this revision. REVISION SUMMARY It's a feature offered by several editors. Now we allow to render none, only t