D19161: Use QTextFormat::TextUnderlineStyle instead of QTextFormat::FontUnderline

ahmadsamir added a comment. > ! In D19161#415702 , @dhaumann wrote: > Btw, searching in lxr.kde.org for FontUnderline reveals some more hits: https://lxr.kde.org/ident?_i=FontUnderline&_remember=1 Turns out these are false positives; I checke

D19161: Use QTextFormat::TextUnderlineStyle instead of QTextFormat::FontUnderline

This revision was automatically updated to reflect the committed changes. Closed by commit R39:8fb410574b14: Use QTextFormat::TextUnderlineStyle instead of QTextFormat::FontUnderline (authored by ahmadsamir, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https:/

D19161: Use QTextFormat::TextUnderlineStyle instead of QTextFormat::FontUnderline

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Given the docs explicitly state one shall use the new enum value, I think this should go in. REPOSITORY R39 KTextEditor BRANCH syntax-hl (branched from master) REVISION DETAIL h

D19161: Use QTextFormat::TextUnderlineStyle instead of QTextFormat::FontUnderline

ahmadsamir added a comment. In D19161#415701 , @dhaumann wrote: > This patch looks good to me, even though I cannot reproduce the issue following the steps in https://bugs.kde.org/show_bug.cgi?id=399278. Another way to test, try setting t

D19161: Use QTextFormat::TextUnderlineStyle instead of QTextFormat::FontUnderline

dhaumann added a comment. Btw, searching in lxr.kde.org for FontUnderline reveals some more hits: https://lxr.kde.org/ident?_i=FontUnderline&_remember=1 REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19161 To: ahmadsamir, #ktexteditor, cullmann, dhaumann Cc: kde

D19161: Use QTextFormat::TextUnderlineStyle instead of QTextFormat::FontUnderline

dhaumann added a comment. This patch looks good to me, even though I cannot reproduce the issue following the steps in https://bugs.kde.org/show_bug.cgi?id=399278. But yes, the Qt documentation says to use TextUnderlineStyle instead of FontUnderline. The implementation of fontUnderline()

D19161: Use QTextFormat::TextUnderlineStyle instead of QTextFormat::FontUnderline

ahmadsamir created this revision. ahmadsamir added reviewers: KTextEditor, cullmann, dhaumann. Herald added projects: Kate, Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY QTextFormat::FontUnderline has been deprecated upstream for a long time. It seems that for s