This revision was automatically updated to reflect the committed changes.
Closed by commit R241:d996ee0a4453: Middle-elide very long filenames in error
strings (authored by ngraham).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D19103?vs=51931&id=52446
REVISION
elvisangelaccio accepted this revision.
elvisangelaccio added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> job_error.cpp:30
>
> +static const int maxFilePathLength = 80;
> +
Maybe it's worth using the `s_` prefix here.
REPOSITORY
R241 KIO
BRANCH
squ
ngraham added a comment.
Ping.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D19103
To: ngraham, #frameworks, #dolphin
Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns
ngraham updated this revision to Diff 51931.
ngraham added a comment.
Make the length a variable
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D19103?vs=51919&id=51931
BRANCH
squeeze-very-long-filenames (branched from master)
REVISION DETAIL
https://phabr
elvisangelaccio added a comment.
Please use a variable instead of hardcoding the length in multiple places.
+1 otherwise.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D19103
To: ngraham, #frameworks, #dolphin
Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ng
ngraham added a comment.
Question: is 80 characters too few? Should I increase it to something higher?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D19103
To: ngraham, #frameworks, #dolphin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
ngraham created this revision.
ngraham added reviewers: Frameworks, Dolphin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.
REVISION SUMMARY
Middle-elide very long filenames used in error strings to prevent broken
