This revision was automatically updated to reflect the committed changes.
astippich marked an inline comment as done.
Closed by commit R286:f4c72f517911: Add a test for ffmpeg extractor (authored
by astippich).
REPOSITORY
R286 KFileMetaData
CHANGES SINCE LAST UPDATE
https://phabricator.kde.o
bruns accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R286 KFileMetaData
BRANCH
ffmpeg_tests
REVISION DETAIL
https://phabricator.kde.org/D19099
To: astippich, bruns, ngraham, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich,
astippich marked an inline comment as done.
astippich added inline comments.
INLINE COMMENTS
> bruns wrote in ffmpegextractortest.cpp:45
> I find it somewhat difficult to grasp `Title` is
> KFileMetaData::Property::Title.
> You can use something like:
>
> namespace KFMProp = KFileMetaData::P
astippich updated this revision to Diff 51990.
astippich added a comment.
- emphasize test properties
REPOSITORY
R286 KFileMetaData
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D19099?vs=51915&id=51990
BRANCH
ffmpeg_tests
REVISION DETAIL
https://phabricator.kde.org/D19099
bruns added inline comments.
INLINE COMMENTS
> ffmpegextractortest.cpp:45
> +
> +QCOMPARE(result.properties().value(Title).toString(),
> QStringLiteral("Title"));
> +QCOMPARE(result.properties().value(Copyright).toString(),
> QStringLiteral("Copyright"));
I find it somewhat difficult t
astippich added a dependent revision: D19100: Cleanup ffmpeg extractor.
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D19099
To: astippich, bruns, ngraham, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun,
ngraham, bruns, abr
astippich created this revision.
astippich added reviewers: bruns, ngraham, mgallien.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
astippich requested review of this revision.
REVISION SUMMARY
Test the ffmpegextractor using
a test file. The f
