D19005: android: don't default to gcc anymore

2019-07-21 Thread Albert Astals Cid
aacid closed this revision. aacid added a comment. Talked with Aleix, we're deciding to drop this for the moment REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D19005 To: apol, #frameworks, vkrause Cc: aacid, kde-frameworks-devel, kde-buildsystem, LeGast0

D19005: android: don't default to gcc anymore

2019-02-18 Thread Volker Krause
vkrause added a comment. In D19005#414313 , @apol wrote: > In D19005#412258 , @vkrause wrote: > > > Actually having tested this, "deprecated_value" looks wrong there, shouldn't this be "default_valu

D19005: android: don't default to gcc anymore

2019-02-17 Thread Aleix Pol Gonzalez
apol added a comment. In D19005#412258 , @vkrause wrote: > Actually having tested this, "deprecated_value" looks wrong there, shouldn't this be "default_value"? no, the value is coming from the cache, so that's the one we're setting. What

D19005: android: don't default to gcc anymore

2019-02-14 Thread Volker Krause
vkrause added a comment. In fact none of those seem to work here. D19016 works here though, and I suspect that the 14 -> 21 in there should fix ECM on the CI. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kd

D19005: android: don't default to gcc anymore

2019-02-14 Thread Volker Krause
vkrause added a comment. Actually having tested this, "deprecated_value" looks wrong there, shouldn't this be "default_value"? REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D19005 To: apol, #frameworks, vkrause Cc: kde-frameworks-devel,

D19005: android: don't default to gcc anymore

2019-02-14 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D19005 To: apol, #frameworks, vkrause Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D19005: android: don't default to gcc anymore

2019-02-14 Thread Aleix Pol Gonzalez
apol created this revision. apol added a reviewer: Frameworks. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY It's deprecated REPOSITORY R240 Extra CMake Modules BRANCH