cullmann closed this revision.
cullmann added a comment.
The build issue got fixed.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D18996
To: davschul, vkrause
Cc: cgiboudeaux, cullmann, kwrite-devel, kde-frameworks-devel, gennad,
bmortimer, domson, mich
cgiboudeaux added inline comments.
INLINE COMMENTS
> CMakeLists.txt:68
> set_property(TARGET SyntaxHighlightingData PROPERTY
> POSITION_INDEPENDENT_CODE 1)
> +target_link_libraries(SyntaxHighlightingData PRIVATE Qt5::Core)
This is causing a build issue (at least) with CMake 3.10:
> CMake Erro
cullmann added a comment.
No problem, I just reopened it that I remember to take a look again at it
myself.
I just run into this issue wanting to land some patches on a openSUSE Leap
machine.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D18996
To: d
davschul added a comment.
Okay I've tested it with 3.12.2 and there were no issues.
I'm not familiar enough with cmake to tell whether there is a simpler version
for what I try to achieve here. I just need the -D QT_NAMESPACE compiler
options. Is there someone in the community who might kno
cullmann reopened this revision.
cullmann added a comment.
This revision is now accepted and ready to land.
Hmm, there is one issue:
With older cmake, aka
cmake version 3.10.2
I get now:
CMake Error at data/CMakeLists.txt:68 (target_link_libraries):
Object library tar
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:96466afebf63: Fix building with namespaced Qt (authored
by davschul, committed by cullmann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D18996?vs=516
vkrause accepted this revision.
vkrause added a comment.
This revision is now accepted and ready to land.
Looks good to me, thanks!
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D18996
To: davschul, vkrause
Cc: cullmann, kwrite-devel, kde-frameworks-deve
cullmann added a comment.
I think target_link_libraries is the right way to fix it, that's OK.
I am not that into the QT_ macro magic, perhaps Volker can comment if
that is ok ;)
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D18996
To: davschul, v
davschul added inline comments.
INLINE COMMENTS
> CMakeLists.txt:62
> set_property(TARGET SyntaxHighlightingData PROPERTY
> POSITION_INDEPENDENT_CODE 1)
> +target_link_libraries(SyntaxHighlightingData PRIVATE Qt5::Core)
This seems like an overkill, but I'm new to CMAKE and it seems that this w
davschul created this revision.
davschul added a reviewer: vkrause.
davschul added a project: Framework: Syntax Highlighting.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
davschul requested review of this revision.
REVISION SUMMARY
Add QT
10 matches
Mail list logo
