This revision was automatically updated to reflect the committed changes.
Closed by commit R216:152968754edc: prevent assertion in regex load (authored
by davschul, committed by cullmann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D18982?vs=516
davschul added a comment.
David Schulz david.sch...@qt.io
REVISION DETAIL
https://phabricator.kde.org/D18982
To: davschul, vkrause, cullmann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, gennad, michaelh,
ngraham, bruns, demsking, sars
cullmann added a comment.
I can push that for you, which user to use? "David Schulz"
REVISION DETAIL
https://phabricator.kde.org/D18982
To: davschul, vkrause, cullmann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, gennad, michaelh,
ngraham, bruns, demsking, sars
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.
I assume Volker profiled it.
I think it is ok to just check if the logging is on.
99% of the syntax definitions are anyways bundled and are checked by the
indexer for such obvious fa
davschul updated this revision to Diff 51643.
davschul added a comment.
added additional context to the diff
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D18982?vs=51588&id=51643
REVISION DETAIL
https://phabricator.kde.org/D18982
AFFECTED FILES
src/lib/rule.cpp
To: davschul,
davschul added inline comments.
INLINE COMMENTS
> dhaumann wrote in rule.cpp:579-582
> I even wonder whether this should be always printed, i.e.:
>
> const bool isValid = m_regexp.isValid();
> if (!isValid)
> qCWarning(...) << "Invalid regexp:" << m_regexp.pattern();
> }
> return i
dhaumann added a comment.
I think that makes a lot of sense. Maybe we should even always print the
warning, not only in debug mode? See comment below...
PS: When submitting patches without phabricator's arc tool, could you add
more diff context, like `git diff -U99 ...`. Then reviewing i
davschul created this revision.
davschul added a reviewer: vkrause.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
davschul requested review of this revision.
REVISION SUMMARY
Instead of crashing the complete application with an assert on a
