D18968: Word-wrap KMessageWidget text

2019-02-17 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R318:cf2da56c5e76: Word-wrap KMessageWidget text (authored by ngraham). REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18968?vs=51554&id=51930 REVISION DETAIL https:/

D18968: Word-wrap KMessageWidget text

2019-02-17 Thread Elvis Angelaccio
elvisangelaccio accepted this revision. REPOSITORY R318 Dolphin BRANCH word-wrap-long-kmessagewidget-text (branched from Applications/18.12) REVISION DETAIL https://phabricator.kde.org/D18968 To: ngraham, #dolphin, #frameworks, cfeck, elvisangelaccio Cc: elvisangelaccio, cfeck, kfm-devel,

D18968: Word-wrap KMessageWidget text

2019-02-17 Thread Nathaniel Graham
ngraham added a comment. Yep, that works great. Did it in D19103: Middle-elide very long filenames in error strings . We'll still need this because word-wrapping the message is also an improvement. REPOSITORY R318 Dolphin BRANCH word-wrap-long-km

D18968: Word-wrap KMessageWidget text

2019-02-17 Thread Elvis Angelaccio
elvisangelaccio added a comment. That could also work, yes. @ngraham wanna give it a try? REPOSITORY R318 Dolphin BRANCH word-wrap-long-kmessagewidget-text (branched from Applications/18.12) REVISION DETAIL https://phabricator.kde.org/D18968 To: ngraham, #dolphin, #frameworks, cfeck C

D18968: Word-wrap KMessageWidget text

2019-02-16 Thread Christoph Feck
cfeck added a comment. Dolphin could simply call KStringHandler::*squeeze(), maybe only on the actual filepath, if squeezing is preferred to wrapping. REPOSITORY R318 Dolphin BRANCH word-wrap-long-kmessagewidget-text (branched from Applications/18.12) REVISION DETAIL https://phabricat

D18968: Word-wrap KMessageWidget text

2019-02-16 Thread Elvis Angelaccio
elvisangelaccio added a comment. @cfeck What if we use a `KSqueezedTextLabel` in `KMessageWidget` instead? That would mostly fix also the '' case without requiring new API in QLabel. REPOSITORY R318 Dolphin BRANCH word-wrap-long-kmessagewidget-text (branched from Application

D18968: Word-wrap KMessageWidget text

2019-02-12 Thread Nathaniel Graham
ngraham updated this revision to Diff 51554. ngraham added a comment. Reference the appropriate Qt bug report REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18968?vs=51551&id=51554 BRANCH word-wrap-long-kmessagewidget-text (branched from Applications/18.

D18968: Word-wrap KMessageWidget text

2019-02-12 Thread Nathaniel Graham
ngraham updated this revision to Diff 51551. ngraham added a comment. Remove bug number in comment REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18968?vs=51538&id=51551 BRANCH word-wrap-long-kmessagewidget-text (branched from Applications/18.12) REVISI

D18968: Word-wrap KMessageWidget text

2019-02-12 Thread Nathaniel Graham
ngraham retitled this revision from "Word-drap KMessageWidget text" to "Word-wrap KMessageWidget text". REPOSITORY R318 Dolphin BRANCH word-wrap-long-kmessagewidget-text (branched from Applications/18.12) REVISION DETAIL https://phabricator.kde.org/D18968 To: ngraham, #dolphin, #framewor