cfeck added a comment.
Well, fix the TODO, and you can remove the comment ;)
I guess QLabel needs new API to set
https://doc.qt.io/qt-5/qtextoption.html#WrapMode-enum
But those plans should be tracked elsewhere, not in source. IMHO, you or
maintainer decides, not me.
REPOSITORY
R
ngraham added a comment.
Well, the code is not wrong but rather incomplete. :) Do you want me to
remove the `TODO: ` too?
REPOSITORY
R318 Dolphin
BRANCH
word-wrap-long-kmessagewidget-text (branched from Applications/18.12)
REVISION DETAIL
https://phabricator.kde.org/D18968
To: ngraha
cfeck accepted this revision.
cfeck added a comment.
This revision is now accepted and ready to land.
I would just remove the comment. The commit references the bug anyway, and a
bug reference in the code is only helpful if the code is wrong, and someone
wants to understand why.
REPOSITORY
ngraham updated this revision to Diff 51538.
ngraham added a comment.
Add a TODO: to the comment
REPOSITORY
R318 Dolphin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D18968?vs=51536&id=51538
BRANCH
word-wrap-long-kmessagewidget-text (branched from Applications/18.12)
REVISION
ngraham created this revision.
ngraham added reviewers: Dolphin, Frameworks.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
ngraham requested review of this revision.
REVISION SUMMARY
Word-wrap KMessageWidget text to prevent the window from being widened
when the text i
