D18960: Add compile check to FindEGL

tcberner added a dependent revision: D19075: Fix FindEGL. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D18960 To: hausmann, vkrause, apol Cc: bcooksley, tcberner, kossebau, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D18960: Add compile check to FindEGL

bcooksley added a comment. /usr/local/bin/gmake -f CMakeFiles/cmTC_fd24d.dir/build.make CMakeFiles/cmTC_fd24d.dir/build gmake[1]: Entering directory '/usr/home/jenkins/kwayland/build/CMakeFiles/CMakeTmp' Building CXX object CMakeFiles/cmTC_fd24d.dir/src.cxx.o /usr/bin/c++ -I/u

D18960: Add compile check to FindEGL

hausmann added a comment. Ooops. Could you paste the error from the cmake error output? I'm curious which part of the EGL compile test fails. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D18960 To: hausmann, vkrause, apol Cc: tcberner, kossebau, kde-fr

D18960: Add compile check to FindEGL

tcberner added a comment. In D18960#411562 , @kossebau wrote: > Seems this is sadly breaking something for FreeBSD though, see > https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/21/console I'll look into it

D18960: Add compile check to FindEGL

kossebau added a comment. Seems this is sadly breaking something for FreeBSD though, see https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/21/console REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D18960 To: hausmann, vkraus

D18960: Add compile check to FindEGL

This revision was automatically updated to reflect the committed changes. Closed by commit R240:0b47899c1b92: Add compile check to FindEGL (authored by hausmann). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18960?vs=51512&id=51574 REVISION DETA

D18960: Add compile check to FindEGL

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D18960 To: hausmann, vkrause, apol Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D18960: Add compile check to FindEGL

vkrause added a comment. +1 This makes sense to me, considering how broken some vendor [E]GL stacks are. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D18960 To: hausmann, vkrause Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D18960: Add compile check to FindEGL

hausmann created this revision. hausmann added a reviewer: vkrause. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. hausmann requested review of this revision. REVISION SUMMARY Perform additional sanity checking REPOSITORY R240