This revision was automatically updated to reflect the committed changes.
Closed by commit R6:b344bc2e3468: Use natural sorting in ActivityModel
(authored by davidedmundson).
REPOSITORY
R6 KActivities
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D18957?vs=51497&id=51948
REVISION DE
apol added inline comments.
INLINE COMMENTS
> activitymodel.h:132
> struct InfoPtrComparator {
> bool operator() (const InfoPtr& left, const InfoPtr& right) const
> {
Do you think it would be possible to store the collator elsewhere?
Re-creating it is a bit expensive to be
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.
Clever!
I believe the bug is about the switcher though, not the KCM.
REPOSITORY
R6 KActivities
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D18957
To: davidedmun
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
ActivityModel sorts internally.
It currently does a non-locale