D18950: KCompressionDevice: reset error in open() to allow reuse of object

2019-02-12 Thread Aleix Pol Gonzalez
apol added inline comments. INLINE COMMENTS > kcompressiondevice.cpp:159 > } > +d->resetErrorCode(); > d->bOpenedUnderlyingDevice = false; Can't you just reset it here without creating a new function that is just used once? REPOSITORY R243 KArchive REVISION DETAIL https://ph

D18950: KCompressionDevice: reset error in open() to allow reuse of object

2019-02-12 Thread Matthias Gerstner
mgerstner created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mgerstner requested review of this revision. REVISION SUMMARY Previously is was not possible to reuse a `KCompressionDevice` object after a call to `open()` failed and `propaga