D18873: add baloo engine debugging category

This revision was automatically updated to reflect the committed changes. Closed by commit R293:f5f1ae889fe9: add baloo engine debugging category (authored by valeriymalov). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18873?vs=51279&id=52220 REVISION DETAIL

D18873: add baloo engine debugging category

bruns added a comment. @valeriymalov - are you going to push this? REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D18873 To: valeriymalov, #baloo, mlaurent, bruns Cc: bruns, mlaurent, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun,

D18873: add baloo engine debugging category

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D18873 To: valeriymalov, #baloo, mlaurent, bruns Cc: bruns, mlaurent, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, s

D18873: add baloo engine debugging category

mlaurent accepted this revision. mlaurent added a comment. Now it's ok for me :) Thanks REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D18873 To: valeriymalov, #baloo, mlaurent, bruns Cc: bruns, mlaurent, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spo

D18873: add baloo engine debugging category

bruns added a comment. Looks good to me. @mlaurent ? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D18873 To: valeriymalov, #baloo, mlaurent, bruns Cc: bruns, mlaurent, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, abrahams

D18873: add baloo engine debugging category

valeriymalov updated this revision to Diff 51279. valeriymalov added a comment. is it now how it's supposed to look in the end? not really sure where .category syntax is defined REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18873?vs=51261&id=51279 BRANCH

D18873: add baloo engine debugging category

mlaurent added a comment. ecm_qt_declare_logging_category(kio_timeline_SRCS HEADER kio_timeline_debug.h IDENTIFIER Baloo::KIO_TIMELINE DEFAULT_SEVERITY Warning

D18873: add baloo engine debugging category

bruns added a comment. In D18873#408662 , @mlaurent wrote: > DEFAULT_SEVERITY [WARNING] is false too as you don't force it. i.e. add "DEFAULT_SEVERITY Warning" in ecm_qt_declare_logging_category compare with https://phabricator.kde.org/

D18873: add baloo engine debugging category

mlaurent added a comment. DEFAULT_SEVERITY [WARNING] is false too as you don't force it. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D18873 To: valeriymalov, #baloo, mlaurent, bruns Cc: bruns, mlaurent, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoo

D18873: add baloo engine debugging category

mlaurent added a comment. Baloo::ENGINE it's wrong as you generate it as "IDENTIFIER "ENGINE" CATEGORY_NAME "org.kde.baloo.engine")" it's not Baloo::ENGINE but ENGINE so you need to change IDENTIFIER "ENGINE" in ecm_qt_declare_logging_category( REPOSITORY R293 Baloo REVISION DETAIL

D18873: add baloo engine debugging category

valeriymalov updated this revision to Diff 51261. valeriymalov added a comment. - update categories per review REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18873?vs=51255&id=51261 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18873 AFFEC

D18873: add baloo engine debugging category

bruns requested changes to this revision. bruns added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > baloo.categories:4 > kf5.kio.kio_timeline Baloo Timeline (KIO) DEFAULT_SEVERITY [WARNING] > IDENTIFIER [Baloo::KIO_TIMELINE] > +org.kde.baloo.engine Baloo engi

D18873: add baloo engine debugging category

valeriymalov added a dependent revision: D18664: Baloo engine: treat every non-success code as a failure. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D18873 To: valeriymalov, #baloo, mlaurent Cc: mlaurent, kde-frameworks-devel, ashaposhnikov, michaelh,

D18873: add baloo engine debugging category

mlaurent accepted this revision. mlaurent added a comment. This revision is now accepted and ready to land. Ok so you need to commit this one first and making second patch dependancy against it. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D18873 To

D18873: add baloo engine debugging category

valeriymalov marked an inline comment as done. valeriymalov added inline comments. INLINE COMMENTS > mlaurent wrote in CMakeLists.txt:31 > which files uses it ? > you generate it but it seems that you don't use it in file no ? I've been asked to split this from D18664: Baloo engine: treat every

D18873: add baloo engine debugging category

valeriymalov updated this revision to Diff 51255. valeriymalov added a comment. - use new syntax for baloo.categories REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18873?vs=51248&id=51255 BRANCH master REVISION DETAIL https://phabricator.kde.org/D18873

D18873: add baloo engine debugging category

mlaurent requested changes to this revision. mlaurent added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > baloo.categories:4 > kf5.kio.kio_timeline Baloo Timeline (KIO) DEFAULT_SEVERITY [WARNING] > IDENTIFIER [Baloo::KIO_TIMELINE] > +org.kde.baloo.engine Balo

D18873: add baloo engine debugging category

valeriymalov created this revision. valeriymalov added a reviewer: Baloo. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. valeriymalov requested review of this revision. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.o