D18791: QuotedPrintableDecoder::decode: return false on error instead of asserting

2019-02-06 Thread Volker Krause
vkrause added a comment. This looks ok to me. The documentation doesn't really specify what should happen on error esp. regarding the return value, but asserting is clearly the wrong approach. REPOSITORY R270 KCodecs REVISION DETAIL https://phabricator.kde.org/D18791 To: aacid Cc: vkra

D18791: QuotedPrintableDecoder::decode: return false on error instead of asserting

2019-02-06 Thread Albert Astals Cid
aacid added a comment. N, i commited this by mistake. Can anyone still please review and tell me if it's wrong and i'll revert? REPOSITORY R270 KCodecs REVISION DETAIL https://phabricator.kde.org/D18791 To: aacid Cc: vkrause, kde-frameworks-devel, michaelh, ngraham,

D18791: QuotedPrintableDecoder::decode: return false on error instead of asserting

2019-02-06 Thread Albert Astals Cid
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R270:26cee94dc4f3: QuotedPrintableDecoder::decode: return false on error instead of asserting (authored by aacid). REPOSITO

D18791: QuotedPrintableDecoder::decode: return false on error instead of asserting

2019-02-06 Thread Albert Astals Cid
aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY let's the fuzzying process continue forward REPOSITORY R270 KCodecs BRANCH master REVISION DETAIL https://phabricat