D18738: Add ebook thumbnailer

broulik closed this revision. broulik added a comment. https://cgit.kde.org/kio-extras.git/commit/?id=db7e30823b8a26b1f8bec721f2079bed6132a155 REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D18738 To: broulik, #plasma, #vdg, elvisangelaccio Cc: elvisangelaccio, a

D18738: Add ebook thumbnailer

elvisangelaccio accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D18738 To: broulik, #plasma, #vdg, elvisangelaccio Cc: elvisangelaccio, abetts, ngraham, kde-frameworks-devel, kfm-devel, alexde, f

D18738: Add ebook thumbnailer

ngraham added a comment. do we have a shipit? Looks good to me too! REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D18738 To: broulik, #plasma, #vdg Cc: elvisangelaccio, abetts, ngraham, kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, navarr

D18738: Add ebook thumbnailer

broulik updated this revision to Diff 51037. broulik added a comment. - Use proper cmake thing REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18738?vs=50896&id=51037 REVISION DETAIL https://phabricator.kde.org/D18738 AFFECTED FILES thumbnail/CMakeL

D18738: Add ebook thumbnailer

elvisangelaccio added a comment. LGTM INLINE COMMENTS > CMakeLists.txt:265 > + > +install(TARGETS ebookthumbnail DESTINATION ${PLUGIN_INSTALL_DIR}) > + `PLUGIN_INSTALL_DIR` is deprecated, new code should use `KDE_INSTALL_PLUGINDIR` REPOSITORY R320 KIO Extras REVISION DETAIL https://pha

D18738: Add ebook thumbnailer

ngraham accepted this revision as: VDG. ngraham added a comment. VDG,approved, still needs a proper code review. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D18738 To: broulik, #plasma, #vdg Cc: abetts, ngraham, kde-frameworks-devel, kfm-devel, alexde, feverfew

D18738: Add ebook thumbnailer

ngraham added a comment. Quite lovely. With the latest changes, this now generates thumbnails for all my my ePubs that have a cover page defined. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D18738 To: broulik, #plasma, #vdg Cc: abetts, ngraham, kde-frameworks-

D18738: Add ebook thumbnailer

broulik updated this revision to Diff 50896. broulik added a comment. - Resolve path to cover relative to OPF file - Search for `iTunesArtwork` as fallback - Search for any file `*cover*` as fallback REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D187

D18738: Add ebook thumbnailer

abetts added a comment. +1 Awesome! REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D18738 To: broulik, #plasma, #vdg Cc: abetts, ngraham, kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, bruns, emmanue

D18738: Add ebook thumbnailer

ngraham added a comment. Works great for most of my ePubs. Here's an archive of some public-domain books in my collection that don't work.F6587654: ePubs that don't get thumbnails.tar.gz INLINE COMMENTS > ebookthumbnail.desktop:3 > +Type=Service > +Nam

D18738: Add ebook thumbnailer

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D18738 To: broulik, #plasma, #vdg Cc: kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, navarromorales, fir

D18738: Add ebook thumbnailer

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY This can extract thumbnails from epub and fb2 ("fiction book", b