This revision was automatically updated to reflect the committed changes.
Closed by commit R127:818e0d1fcb65: Make XdgTest spec compliant (authored by
davidedmundson).
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D18577?vs=50422&id=50425
REVISION DETAIL
h
davidedmundson updated this revision to Diff 50422.
davidedmundson added a comment.
update
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D18577?vs=50420&id=50422
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D18577
AFFECTED FILES
tests
zzag accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R127 KWayland
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D18577
To: davidedmundson, #kwin, zzag
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns
zzag added inline comments.
INLINE COMMENTS
> xdgtest.cpp:124
> Q_ASSERT(m_xdgShellSurface);
> -connect(m_xdgShellSurface, &XdgShellSurface::sizeChanged, this,
> &XdgTest::render);
> -render();
> +connect(m_xdgShellSurface, &XdgShellSurface::confi
davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
Right now it worked in kwin, but was in fact breaking the spec send
