dfaure added a comment.
Looks good. This assumes that no process exits cleanly (code 0) while not
showing anything to the user, but even if that happened, better no klauncher
error in that case, than an error in a normal case like the kate one.
INLINE COMMENTS
> klauncher.cpp:340
> +
ahmadsamir updated this revision to Diff 48948.
ahmadsamir edited the summary of this revision.
ahmadsamir added a comment.
Fix commit message
REPOSITORY
R303 KInit
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D18089?vs=48947&id=48948
BRANCH
klauncher-kateSessionManager (branc
ahmadsamir added a reviewer: dfaure.
REPOSITORY
R303 KInit
REVISION DETAIL
https://phabricator.kde.org/D18089
To: ahmadsamir, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
ahmadsamir created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ahmadsamir requested review of this revision.
REVISION SUMMARY
When a process dies with exitStatus 0, it could well be the app exited
cleanly, and there's no need to display a
