D18038: Fix semantics for ghns_exclude

This revision was automatically updated to reflect the committed changes. Closed by commit R304:301fe73569ba: Fix semantics for ghns_exclude (authored by leinir). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18038?vs=48859&id=49339 REVISION DETAIL https

D18038: Fix semantics for ghns_exclude

leinir edited the summary of this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D18038 To: leinir, ronaldv, #kde_store, ngraham Cc: kde-frameworks-devel, michaelh, ZrenBot, ngraham, bruns, akiraohgaki, alexanderschmidt, siyuandong, ronaldv, mikesomov, starb

D18038: Fix semantics for ghns_exclude

leinir added a comment. In D18038#391684 , @ngraham wrote: > Thanks, in addition to the testing tool working, this patch seems to actually fix the issue in production (e.g. "Tree on Island" is no longer visible in the wallpaper downloader), and

D18038: Fix semantics for ghns_exclude

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks, in addition to the testing tool working, this patch seems to actually fix the issue in production (e.g. "Tree on Island" is no longer visible in the wallpaper downloader), and as

D18038: Fix semantics for ghns_exclude

leinir added a comment. In D18038#390748 , @ngraham wrote: > What is the test tool? Can you help a total n00b like me learn how to test KNewStuff patches like these? The test tool is khotnewstuff_test in tests/. It's not installed, but on

D18038: Fix semantics for ghns_exclude

ngraham added a comment. What is the test tool? Can you help a total n00b like me learn how to test KNewStuff patches like these? Also, the correct formatting is `CCBUG: 402888`. See https://community.kde.org/Infrastructure/Phabricator#Formatting_your_patch REPOSITORY R304 KNewStuff

D18038: Fix semantics for ghns_exclude

leinir added a reviewer: ngraham. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D18038 To: leinir, ronaldv, #kde_store, ngraham Cc: kde-frameworks-devel, michaelh, ZrenBot, ngraham, bruns, akiraohgaki, alexanderschmidt, siyuandong, ronaldv, mikesomov, starbuck

D18038: Fix semantics for ghns_exclude

leinir created this revision. leinir added reviewers: ronaldv, KDE Store. leinir added projects: KNewStuff, KDE Store. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY After much discussion on the topi