D17718: Use ECMGeneratePkgConfigFile to create the pkgconfig file.

2018-12-21 Thread Christophe Giboudeaux
cgiboudeaux added a comment. Reverted and the version was fixed. REPOSITORY R6 KActivities REVISION DETAIL https://phabricator.kde.org/D17718 To: cgiboudeaux, cfeck, #build_system Cc: pino, alexeymin, kde-frameworks-devel, michaelh, ngraham, bruns

D17718: Use ECMGeneratePkgConfigFile to create the pkgconfig file.

2018-12-21 Thread Christophe Giboudeaux
cgiboudeaux removed a reviewer: alexeymin. cgiboudeaux added a comment. In D17718#380267 , @pino wrote: > In D17718#380261 , @alexeymin wrote: > > > I tested this, it indeed fixes 390225 > > Witho

D17718: Use ECMGeneratePkgConfigFile to create the pkgconfig file.

2018-12-21 Thread Pino Toscano
pino added a comment. In D17718#380261 , @alexeymin wrote: > I tested this, it indeed fixes 390225 > Withoug this patch, generated pkgconfig file was: > > prefix=/usr > exec_prefix=bin > libdir=lib/x86_64-linux-gnu > included

D17718: Use ECMGeneratePkgConfigFile to create the pkgconfig file.

2018-12-21 Thread Christophe Giboudeaux
This revision was automatically updated to reflect the committed changes. Closed by commit R6:52267908a1e4: Use ECMGeneratePkgConfigFile to create the pkgconfig file. (authored by cgiboudeaux). REPOSITORY R6 KActivities CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17718?vs=47934&id

D17718: Use ECMGeneratePkgConfigFile to create the pkgconfig file.

2018-12-21 Thread Alexey Min
alexeymin accepted this revision. alexeymin added a comment. This revision is now accepted and ready to land. I tested this, it indeed fixes 390225 Withoug this patch, generated pkgconfig file was: prefix=/usr exec_prefix=bin libdir=lib/x86_64-linux-gnu includedir=include

D17718: Use ECMGeneratePkgConfigFile to create the pkgconfig file.

2018-12-21 Thread Christophe Giboudeaux
cgiboudeaux added reviewers: cfeck, Build System. REPOSITORY R6 KActivities REVISION DETAIL https://phabricator.kde.org/D17718 To: cgiboudeaux, cfeck, #build_system Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17718: Use ECMGeneratePkgConfigFile to create the pkgconfig file.

2018-12-21 Thread Christophe Giboudeaux
cgiboudeaux created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cgiboudeaux requested review of this revision. REVISION SUMMARY This also fixes the version in the .pc file. BUG 390225 FIXED-IN: 5.55 REPOSITORY R6 KActivities BRAN