D17714: Clang: don't enable -Wzero-as-null-pointer-constant on 5.0.0

2018-12-20 Thread David Faure
dfaure added a comment. Damn, I went too fast. This doesn't fix the issue. CMake says 5.0.300080 is > 5.0.1, obviously. The reason I enabled it for 5.0.1 is that on x86_64 linux, clang 5.0.1 does support it (but now I realize that 5.0.0 does too, most probably). I don't understand

D17714: Clang: don't enable -Wzero-as-null-pointer-constant on 5.0.0

2018-12-20 Thread David Faure
dfaure closed this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D17714 To: dfaure, aacid, cgiboudeaux, apol Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D17714: Clang: don't enable -Wzero-as-null-pointer-constant on 5.0.0

2018-12-20 Thread Christophe Giboudeaux
cgiboudeaux accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D17714 To: dfaure, aacid, cgiboudeaux, apol Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, brun

D17714: Clang: don't enable -Wzero-as-null-pointer-constant on 5.0.0

2018-12-20 Thread David Faure
dfaure created this revision. dfaure added reviewers: aacid, cgiboudeaux, apol. Herald added projects: Frameworks, Build System. Herald edited subscribers, added: kde-buildsystem, kde-frameworks-devel; removed: Build System, Frameworks. dfaure requested review of this revision. REVISION SUMMARY